From 593b5cf148123627018613941d19169fbaee3879 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 5 May 2026 17:19:06 +0200 Subject: [PATCH] protocol-simple: close client_fd when client alloc fails --- src/modules/module-protocol-simple.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/modules/module-protocol-simple.c b/src/modules/module-protocol-simple.c index 3a405684d..172debd4e 100644 --- a/src/modules/module-protocol-simple.c +++ b/src/modules/module-protocol-simple.c @@ -588,14 +588,13 @@ on_connect(void *data, int fd, uint32_t mask) goto error; if (server->n_clients >= MAX_CLIENTS) { - close(client_fd); errno = ECONNREFUSED; - goto error; + goto error_close; } client = calloc(1, sizeof(struct client)); if (client == NULL) - goto error; + goto error_close; client->impl = impl; client->server = server; @@ -654,6 +653,9 @@ on_connect(void *data, int fd, uint32_t mask) create_streams(impl, client); return; + +error_close: + close(client_fd); error: pw_log_error("%p: failed to create client: %m", impl); pw_properties_free(props);