mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-10 13:30:05 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

context: set zero_denormals in data thread.

Browse source 
Use invoke to set the zero-denormals flag from the data thread when
explicitly set. The flag is per thread and should really only be set on
the data thread and only when explicitly enabled.

Fixes #2160
This commit is contained in:
Wim Taymans 2022-02-22 11:31:06 +01:00
parent 62ae9b7d30
commit 542b0acd73
3 changed files with 21 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/daemon/minimal.conf.in
View file

@ -20,7 +20,7 @@ context.properties = {
#mem.mlock-all = false #mem.mlock-all = false
#clock.power-of-two-quantum = true #clock.power-of-two-quantum = true
#log.level = 2 #log.level = 2
#cpu.zero.denormals = true #cpu.zero.denormals = false
core.daemon = true # listening for socket connections core.daemon = true # listening for socket connections
core.name = pipewire-0 # core name and socket name core.name = pipewire-0 # core name and socket name

2
src/daemon/pipewire.conf.in
View file

@ -20,7 +20,7 @@ context.properties = {
#mem.mlock-all = false #mem.mlock-all = false
#clock.power-of-two-quantum = true #clock.power-of-two-quantum = true
#log.level = 2 #log.level = 2
#cpu.zero.denormals = true #cpu.zero.denormals = false
core.daemon = true # listening for socket connections core.daemon = true # listening for socket connections
core.name = pipewire-0 # core name and socket name core.name = pipewire-0 # core name and socket name

21
src/pipewire/context.c
View file

@ -178,6 +178,22 @@ static void init_plugin_loader(struct impl *impl)
impl); impl);
} }
static int do_data_loop_setup(struct spa_loop *loop, bool async, uint32_t seq,
const void *data, size_t size, void *user_data)
{
struct pw_context *this = user_data;
const char *str;
struct spa_cpu *cpu;
cpu = spa_support_find(this->support, this->n_support, SPA_TYPE_INTERFACE_CPU);
if ((str = pw_properties_get(this->properties, SPA_KEY_CPU_ZERO_DENORMALS)) != NULL &&
cpu != NULL) {
pw_log_info("setting zero denormals: %s", str);
spa_cpu_zero_denormals(cpu, spa_atob(str));
}
return 0;
}
/** Create a new context object /** Create a new context object
* *
@ -290,8 +306,6 @@ struct pw_context *pw_context_new(struct pw_loop *main_loop,
if (pw_properties_get(properties, PW_KEY_CPU_MAX_ALIGN) == NULL) if (pw_properties_get(properties, PW_KEY_CPU_MAX_ALIGN) == NULL)
pw_properties_setf(properties, PW_KEY_CPU_MAX_ALIGN, pw_properties_setf(properties, PW_KEY_CPU_MAX_ALIGN,
"%u", spa_cpu_get_max_align(cpu)); "%u", spa_cpu_get_max_align(cpu));
if ((str = pw_properties_get(properties, SPA_KEY_CPU_ZERO_DENORMALS)) != NULL)
spa_cpu_zero_denormals(cpu, spa_atob(str));
} }
if (getenv("PIPEWIRE_DEBUG") == NULL && if (getenv("PIPEWIRE_DEBUG") == NULL &&
@ -394,6 +408,9 @@ struct pw_context *pw_context_new(struct pw_loop *main_loop,
if ((res = pw_data_loop_start(this->data_loop_impl)) < 0) if ((res = pw_data_loop_start(this->data_loop_impl)) < 0)
goto error_free; goto error_free;
pw_data_loop_invoke(this->data_loop_impl,
do_data_loop_setup, 0, NULL, 0, false, this);
context_set_freewheel(this, false); context_set_freewheel(this, false);
pw_settings_expose(this); pw_settings_expose(this);