mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-12-16 08:56:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

improve error handling

Browse source 
Set errno for functions returning NULL if relevant.
Propagate errno and result codes better.
Handle more error cases.
This commit is contained in:
Wim Taymans 2019-06-07 10:11:23 +02:00
parent 0a5bce4a3b
commit 504d78cd18
26 changed files with 359 additions and 148 deletions
Download patch file Download diff file Expand all files Collapse all files

15
spa/plugins/support/dbus.c
View file

@ -286,6 +286,7 @@ impl_get_connection(void *object,
struct impl *impl = object;
struct connection *conn;
DBusError error;
int res;
dbus_error_init(&error);
@ -298,6 +299,8 @@ impl_get_connection(void *object,
conn->dispatch_event = spa_loop_utils_add_idle(impl->utils,
false, dispatch_cb, conn);
if (conn->dispatch_event == NULL)
goto no_event;
dbus_connection_set_exit_on_disconnect(conn->conn, false);
dbus_connection_set_dispatch_status_function(conn->conn, dispatch_status, conn, NULL);
@ -314,7 +317,19 @@ impl_get_connection(void *object,
error:
spa_log_error(impl->log, "Failed to connect to system bus: %s", error.message);
dbus_error_free(&error);
res = -ECONNREFUSED;
goto out_free;
no_event:
res = -errno;
spa_log_error(impl->log, "Failed to create idle event: %m");
goto out_unref_dbus;
out_unref_dbus:
dbus_connection_close(conn->conn);
dbus_connection_unref(conn->conn);
out_free:
free(conn);
errno = -res;
return NULL;
}