mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-05-19 21:37:36 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

treewide: add error checking to spa_json_builder_close

Browse source 
There could have been a write error or allocation error while building
the json file that we can detect in spa_json_builder_close().

Error out instead of silently using a truncated JSON.

Use spa_autofree for the memory to make cleanup easier.
This commit is contained in:
Wim Taymans 2026-05-13 18:14:44 +02:00
parent 6d1c242433
commit 4f975d0071
41 changed files with 240 additions and 194 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/tools/pw-loopback.c
View file

@ -11,6 +11,7 @@
#include <math.h>
#include <locale.h>
#include <spa/utils/cleanup.h>
#include <spa/utils/result.h>
#include <spa/pod/builder.h>
#include <spa/param/audio/format-utils.h>
@ -94,7 +95,7 @@ int main(int argc, char *argv[])
const char *opt_remote = NULL, *remote_name;
char cname[256];
struct spa_json_builder b;
char *args;
spa_autofree char *args = NULL;
size_t size;
static const struct option long_options[] = {
{ "help", no_argument, NULL, 'h' },
@ -251,14 +252,14 @@ int main(int argc, char *argv[])
pw_properties_serialize_dict(b.f, &data.playback_props->dict, 0);
spa_json_builder_pop(&b, "}");
spa_json_builder_pop(&b, "}");
spa_json_builder_close(&b);
if ((res = spa_json_builder_close(&b)) < 0)
goto exit;
pw_log_info("loading module with %s", args);
data.module = pw_context_load_module(data.context,
"libpipewire-module-loopback", args,
NULL);
free(args);
if (data.module == NULL) {
fprintf(stderr, "can't load module: %m\n");