mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use int instead of bool as result

Browse source 
Prefer to use an int return from a function instead of bool because
it can contain more info about failures.
This commit is contained in:
Wim Taymans 2017-12-18 11:38:30 +01:00
parent e5e360d5df
commit 4d6ac37398
38 changed files with 308 additions and 297 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/modules/module-flatpak.c
View file

@ -752,7 +752,7 @@ static const struct pw_module_events module_events = {
.destroy = module_destroy,
};
static bool module_init(struct pw_module *module, struct pw_properties *properties)
static int module_init(struct pw_module *module, struct pw_properties *properties)
{
struct pw_core *core = pw_module_get_core(module);
struct impl *impl;
@ -761,6 +761,9 @@ static bool module_init(struct pw_module *module, struct pw_properties *properti
dbus_error_init(&error);
impl = calloc(1, sizeof(struct impl));
if (impl == NULL)
return -ENOMEM;
pw_log_debug("module %p: new", impl);
impl->core = core;
@ -788,27 +791,16 @@ static bool module_init(struct pw_module *module, struct pw_properties *properti
pw_core_set_permission_callback(core, do_permission, impl);
return true;
return 0;
error:
free(impl);
pw_log_error("Failed to connect to system bus: %s", error.message);
dbus_error_free(&error);
return false;
return -ENOMEM;
}
#if 0
static void module_destroy(struct impl *impl)
{
pw_log_debug("module %p: destroy", impl);
dbus_connection_close(impl->bus);
dbus_connection_unref(impl->bus);
free(impl);
}
#endif
bool pipewire__module_init(struct pw_module *module, const char *args)
int pipewire__module_init(struct pw_module *module, const char *args)
{
return module_init(module, NULL);
}