mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

spa: aec: webrtc: Drop outdated comment

Browse source 
The Intelligibility enhancer was removed, so the FIXMEs are irrelevant.
This commit is contained in:
Arun Raghavan 2025-07-09 12:48:24 -04:00
parent a328e0ae28
commit 477674740e
1 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
spa/plugins/aec/aec-webrtc.cpp
View file

@ -124,10 +124,6 @@ static int webrtc_init2(void *object, const struct spa_dict *args,
// result in very poor performance, disable by default // result in very poor performance, disable by default
bool gain_control = webrtc_get_spa_bool(args, "webrtc.gain_control", false); bool gain_control = webrtc_get_spa_bool(args, "webrtc.gain_control", false);
// FIXME: Intelligibility enhancer is not currently supported
// This filter will modify playback buffer (when calling ProcessReverseStream), but now
// playback buffer modifications are discarded.
#if defined(HAVE_WEBRTC) #if defined(HAVE_WEBRTC)
webrtc::Config config; webrtc::Config config;
config.Set<webrtc::ExtendedFilter>(new webrtc::ExtendedFilter(extended_filter)); config.Set<webrtc::ExtendedFilter>(new webrtc::ExtendedFilter(extended_filter));
@ -309,9 +305,6 @@ static int webrtc_run(void *object, const float *rec[], const float *play[], flo
for (size_t j = 0; j < impl->out_info.channels; j++) for (size_t j = 0; j < impl->out_info.channels; j++)
impl->out_buffer[j] = out[j] + out_config.num_frames() * i; impl->out_buffer[j] = out[j] + out_config.num_frames() * i;
/* FIXME: ProcessReverseStream may change the playback buffer, in which
* case we should use that, if we ever expose the intelligibility
* enhancer */
if ((res = impl->apm->ProcessReverseStream(impl->play_buffer.get(), if ((res = impl->apm->ProcessReverseStream(impl->play_buffer.get(),
play_config, play_config, impl->play_buffer.get())) != play_config, play_config, impl->play_buffer.get())) !=
webrtc::AudioProcessing::kNoError) { webrtc::AudioProcessing::kNoError) {