mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pulse-server: show warning about snap kernel features only once

Browse source 
Don't spam the warning about kernel missing features required for snap
on every pulseaudio connection, but instead show it only once, as the
situation is not going to improve.
This commit is contained in:
Pauli Virtanen 2024-05-01 13:14:51 +03:00
parent d80989ab56
commit 44d958d397
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/modules/module-protocol-pulse/snap-policy.c
View file

@ -66,9 +66,15 @@ pw_sandbox_access_t pw_snap_get_audio_permissions(struct client *client, int fd,
return PW_SANDBOX_ACCESS_NOT_A_SANDBOX; return PW_SANDBOX_ACCESS_NOT_A_SANDBOX;
} }
if (errno == ENOPROTOOPT) { if (errno == ENOPROTOOPT) {
static bool warned;
// if fine grained unix mediation isn't available, we can't know if this is a snap or // if fine grained unix mediation isn't available, we can't know if this is a snap or
// not, so we have no choice but give full access // not, so we have no choice but give full access
pw_log_warn("snap_get_audio_permissions: kernel lacks 'fine grained unix mediation'; snap audio permissions won't be honored."); if (!warned) {
pw_log_warn("snap_get_audio_permissions: kernel lacks 'fine grained unix mediation'; "
"snap audio permissions won't be honored.");
warned = true;
}
return PW_SANDBOX_ACCESS_NOT_A_SANDBOX; return PW_SANDBOX_ACCESS_NOT_A_SANDBOX;
} }
pw_log_warn("snap_get_audio_permissions: failed to get the AppArmor info: %s.", strerror(errno)); pw_log_warn("snap_get_audio_permissions: failed to get the AppArmor info: %s.", strerror(errno));