mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

module-rt: handle pthread_getschedparam() errors correctly

Browse source 
pthread_getschedparam() always returns non-negative values, so checking
if its return value is less than zero always evaluates to false.

Also, pthread functions don't set errno. While logging a warning
message, use the return value of pthread_getschedparam() instead of
errno.
This commit is contained in:
Doğukan Korkmaztürk 2022-07-13 08:09:32 -04:00 • committed by Wim Taymans
parent a458b39774
commit 43602911c6
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/modules/module-rt.c
View file

@ -520,9 +520,8 @@ static const struct pw_impl_module_events module_events = {
*/ */
static bool check_realtime_privileges(rlim_t priority) static bool check_realtime_privileges(rlim_t priority)
{ {
int old_policy; int err, old_policy, new_policy = REALTIME_POLICY;
struct sched_param old_sched_params; struct sched_param old_sched_params;
int new_policy = REALTIME_POLICY;
struct sched_param new_sched_params; struct sched_param new_sched_params;
/* We could check `RLIMIT_RTPRIO`, but the BSDs generally don't have /* We could check `RLIMIT_RTPRIO`, but the BSDs generally don't have
@ -530,8 +529,8 @@ static bool check_realtime_privileges(rlim_t priority)
* scheduling without that rlimit being set such as `CAP_SYS_NICE` or * scheduling without that rlimit being set such as `CAP_SYS_NICE` or
* running as root. Instead of checking a bunch of preconditions, we * running as root. Instead of checking a bunch of preconditions, we
* just try if setting realtime scheduling works or not. */ * just try if setting realtime scheduling works or not. */
if (pthread_getschedparam(pthread_self(),&old_policy,&old_sched_params) < 0) { if ((err = pthread_getschedparam(pthread_self(),&old_policy,&old_sched_params)) != 0) {
pw_log_warn("Failed to check RLIMIT_RTPRIO %m"); pw_log_warn("Failed to check RLIMIT_RTPRIO: %s", strerror(err));
return false; return false;
} }