mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-04-27 06:46:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

security: fix integer overflows in netjack2 peer buffer allocations

Browse source 
Memory Safety: High

In netjack2_init(), several buffer sizes are computed by multiplying
network-provided session parameters (period_size, channel counts,
kbps) without overflow checks. A malicious network peer can send
crafted session parameters that cause these multiplications to
overflow, resulting in undersized buffer allocations. Subsequent
writes to these buffers then overflow the heap.

Specific issues fixed:
1. midi_size = period_size * sizeof(float) * max_midi_channels can
   overflow, causing calloc to allocate a small buffer.
2. encoded_size = max_encoded_size * max_audio_channels can overflow
   for both INT and OPUS encoders.
3. OPUS kbps * period_size * 1024 numerator can overflow uint32_t;
   widen to uint64_t for the intermediate calculation.
4. Division by zero if sample_rate is 0 in OPUS encoder path.
5. Missing NULL checks on calloc for empty and midi_data buffers.
6. Channel counts not capped to MAX_CHANNELS before use.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Wim Taymans 2026-04-23 17:59:39 +02:00
parent 18df76b654
commit 4305d7e82d
1 changed files with 34 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

43
src/modules/module-netjack2/peer.c
View file

@ -135,26 +135,51 @@ struct netjack2_peer {
static int netjack2_init(struct netjack2_peer *peer) static int netjack2_init(struct netjack2_peer *peer)
{ {
int res = 0; int res = 0;
uint32_t max_midi_ch, max_audio_ch;
peer->empty = calloc(peer->quantum_limit, sizeof(float)); if ((peer->empty = calloc(peer->quantum_limit, sizeof(float))) == NULL)
goto error_errno;
peer->midi_size = peer->params.period_size * sizeof(float) * max_midi_ch = SPA_MAX(peer->params.send_midi_channels, peer->params.recv_midi_channels);
SPA_MAX(peer->params.send_midi_channels, peer->params.recv_midi_channels); if (max_midi_ch > MAX_CHANNELS ||
peer->midi_data = calloc(1, peer->midi_size); peer->params.period_size > UINT32_MAX / sizeof(float) / SPA_MAX(max_midi_ch, 1u)) {
errno = EINVAL;
goto error_errno;
}
peer->midi_size = peer->params.period_size * sizeof(float) * max_midi_ch;
if ((peer->midi_data = calloc(1, peer->midi_size)) == NULL && peer->midi_size > 0)
goto error_errno;
max_audio_ch = SPA_MAX(peer->params.send_audio_channels, peer->params.recv_audio_channels);
if (max_audio_ch > MAX_CHANNELS) {
errno = EINVAL;
goto error_errno;
}
if (peer->params.sample_encoder == NJ2_ENCODER_INT) { if (peer->params.sample_encoder == NJ2_ENCODER_INT) {
peer->max_encoded_size = peer->params.period_size * sizeof(int16_t); peer->max_encoded_size = peer->params.period_size * sizeof(int16_t);
peer->encoded_size = peer->max_encoded_size * if (peer->params.period_size > UINT32_MAX / sizeof(int16_t) ||
SPA_MAX(peer->params.send_audio_channels, peer->params.recv_audio_channels); (max_audio_ch > 0 && peer->max_encoded_size > UINT32_MAX / max_audio_ch)) {
errno = EINVAL;
goto error_errno;
}
peer->encoded_size = peer->max_encoded_size * max_audio_ch;
if ((peer->encoded_data = calloc(1, peer->encoded_size)) == NULL) if ((peer->encoded_data = calloc(1, peer->encoded_size)) == NULL)
goto error_errno; goto error_errno;
} else if (peer->params.sample_encoder == NJ2_ENCODER_OPUS) { } else if (peer->params.sample_encoder == NJ2_ENCODER_OPUS) {
#ifdef HAVE_OPUS_CUSTOM #ifdef HAVE_OPUS_CUSTOM
int32_t i; int32_t i;
peer->max_encoded_size = (peer->params.kbps * peer->params.period_size * 1024) / if (peer->params.sample_rate == 0) {
errno = EINVAL;
goto error_errno;
}
peer->max_encoded_size = ((uint64_t)peer->params.kbps * peer->params.period_size * 1024) /
(peer->params.sample_rate * 8) + sizeof(uint16_t); (peer->params.sample_rate * 8) + sizeof(uint16_t);
peer->encoded_size = peer->max_encoded_size * if (max_audio_ch > 0 && peer->max_encoded_size > UINT32_MAX / max_audio_ch) {
SPA_MAX(peer->params.send_audio_channels, peer->params.recv_audio_channels); errno = EINVAL;
goto error_errno;
}
peer->encoded_size = peer->max_encoded_size * max_audio_ch;
if ((peer->encoded_data = calloc(1, peer->encoded_size)) == NULL) if ((peer->encoded_data = calloc(1, peer->encoded_size)) == NULL)
goto error_errno; goto error_errno;
if ((peer->opus_config = opus_custom_mode_create(peer->params.sample_rate, if ((peer->opus_config = opus_custom_mode_create(peer->params.sample_rate,