mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

alsa: remove NoteOn 0-velocity fixup

Browse source 
Pass MIDI events as they are.

JACK requires NoteOn 0-velocity midi events to be patched to NoteOff
events for compatibility with LV2 plugins. Let's do this patchup in
the JACK layer then and add an option to disable it.

It's best to pass the midi messages unmodified and then patch them up
wherever they need patching up.
This commit is contained in:
Wim Taymans 2022-06-20 15:51:33 +02:00
parent d13a206866
commit 40f50deae9
3 changed files with 27 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spa/plugins/alsa/alsa-seq.c
View file

@ -543,12 +543,6 @@ static int process_read(struct seq_state *state)
continue;
}
/* fixup NoteOn with vel 0 */
if ((data[0] & 0xF0) == 0x90 && data[2] == 0x00) {
data[0] = 0x80 + (data[0] & 0x0F);
data[2] = 0x40;
}
/* queue_time is the estimated current time of the queue as calculated by
* the DLL. Calculate the age of the event. */
ev_time = SPA_TIMESPEC_TO_NSEC(&ev->time.time);