From 40eb9578d51583f5cdb9470b0a3d699453f083cf Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Thu, 30 Sep 2021 08:36:01 +1000 Subject: [PATCH] media-session: make a few debug messages easier to understand Especially with PIPEWIRE_LOG_LINE=false, those messages are too confusing otherwise. --- src/media-session/access-flatpak.c | 2 +- src/media-session/access-portal.c | 4 ++-- src/media-session/media-session.c | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/media-session/access-flatpak.c b/src/media-session/access-flatpak.c index 81bbdebbc..46958ac86 100644 --- a/src/media-session/access-flatpak.c +++ b/src/media-session/access-flatpak.c @@ -126,7 +126,7 @@ handle_client(struct impl *impl, struct sm_object *object) { struct client *client; - pw_log_debug("%p: client", impl); + pw_log_debug("%p: new client '%u'", impl, object->id); client = sm_object_add_data(object, SESSION_KEY, sizeof(struct client)); client->obj = (struct sm_client*)object; diff --git a/src/media-session/access-portal.c b/src/media-session/access-portal.c index 30b1a7135..92d95a26b 100644 --- a/src/media-session/access-portal.c +++ b/src/media-session/access-portal.c @@ -198,7 +198,7 @@ handle_client(struct impl *impl, struct sm_object *object) struct client *client; const char *str; - pw_log_debug("%p: client %u", impl, object->id); + pw_log_debug("%p: new client '%u'", impl, object->id); client = sm_object_add_data(object, SESSION_KEY, sizeof(struct client)); client->obj = (struct sm_client*)object; @@ -213,7 +213,7 @@ handle_client(struct impl *impl, struct sm_object *object) (str = pw_properties_get(client->obj->obj.props, PW_KEY_CLIENT_ACCESS)) != NULL) && spa_streq(str, "portal")) { client->portal_managed = true; - pw_log_info("%p: portal managed client %d added", + pw_log_info("%p: portal-managed client %d added", impl, client->id); } return 1; diff --git a/src/media-session/media-session.c b/src/media-session/media-session.c index 3380a8c26..208cf1108 100644 --- a/src/media-session/media-session.c +++ b/src/media-session/media-session.c @@ -2534,6 +2534,7 @@ int main(int argc, char *argv[]) return 0; } + pw_log_info("media-session context properties:"); spa_dict_for_each(item, &impl.this.props->dict) pw_log_info(" '%s' = '%s'", item->key, item->value); @@ -2588,7 +2589,7 @@ int main(int argc, char *argv[]) for (i = 0; i < SPA_N_ELEMENTS(modules); i++) { const char *name = modules[i].name; if (is_module_enabled(&impl, name)) { - pw_log_info("enable: %s", name); + pw_log_info("enabling media session module: %s", name); modules[i].start(&impl.this); } }