mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluez5: bap: prefer 32 kHz in/out for duplex configuration

Browse source 
I'm not aware of any devices that support 48 kHz output in duplex
configuration, so disable that for now.

Doing this properly requires catching errors when on transport Acquire,
and switching to another configuration if the error was due to bad
configuration.

Due to how BAP specification works, it's not necessarily possible to
know whether a configuration was really accepted at earlier stage, and
anyway there's no proper error -> reconfiguration handling currently on
BlueZ side either.
This commit is contained in:
Pauli Virtanen 2025-02-23 19:54:02 +02:00 • committed by Wim Taymans
parent 209820bab8
commit 3ed969144a
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
spa/plugins/bluez5/bap-codec-lc3.c
View file

@ -644,13 +644,17 @@ static bool select_config(bap_lc3_t *conf, const struct pac_data *pac, struct sp
* Frame length is not limited by ISO MTU, as kernel will fragment
* and reassemble SDUs as needed.
*/
if (pac->settings->sink && pac->settings->duplex) {
if (pac->settings->duplex) {
/* 16KHz input is mandatory in BAP v1.0.1 Table 3.5, so prefer
* it for now for input rate in duplex configuration.
* it or 32kHz for now for input rate in duplex configuration.
*
* It appears few devices support 48kHz out + input, so in duplex mode
* try 32 kHz or 16 kHz also for output direction.
*
* Devices may list other values but not certain they will work properly.
*/
found = select_bap_qos(&bap_qos, pac->settings, rate_mask & LC3_FREQ_16KHZ, duration_mask, framelen_min, framelen_max);
found = select_bap_qos(&bap_qos, pac->settings, rate_mask & (LC3_FREQ_16KHZ | LC3_FREQ_32KHZ),
duration_mask, framelen_min, framelen_max);
}
if (!found)
found = select_bap_qos(&bap_qos, pac->settings, rate_mask, duration_mask, framelen_min, framelen_max);
@ -751,8 +755,8 @@ static int conf_cmp(const bap_lc3_t *conf1, int res1, const bap_lc3_t *conf2, in
PREFER_BOOL(conf->channels & LC3_CHAN_2);
PREFER_BOOL(conf->channels & LC3_CHAN_1);
if (conf->sink && conf->duplex)
PREFER_BOOL(conf->rate & LC3_CONFIG_FREQ_16KHZ);
if (conf->duplex)
PREFER_BOOL(conf->rate & (LC3_CONFIG_FREQ_16KHZ | LC3_CONFIG_FREQ_32KHZ));
PREFER_EXPR(conf->priority);