From 3d33acce1d33ef4485a1b1af45a872cf9f2ecf6a Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Tue, 18 Mar 2025 09:38:55 +0100 Subject: [PATCH] netjack: handle overflow in midi buffer append --- src/modules/module-netjack2/peer.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/modules/module-netjack2/peer.c b/src/modules/module-netjack2/peer.c index 8016a048a..a3a20f294 100644 --- a/src/modules/module-netjack2/peer.c +++ b/src/modules/module-netjack2/peer.c @@ -296,8 +296,12 @@ static inline void n2j_midi_buffer_append(struct nj2_midi_buffer *buf, old_ptr = SPA_PTROFF(buf, ev->offset, void); } new_ptr = n2j_midi_buffer_reserve(buf, ev->time, old_size + size); - memmove(new_ptr, old_ptr, old_size); - memcpy(new_ptr+old_size, data, size); + if (new_ptr == NULL) { + buf->lost_events++; + } else { + memmove(new_ptr, old_ptr, old_size); + memcpy(new_ptr+old_size, data, size); + } } static void midi_to_netjack2(struct netjack2_peer *peer,