From 3ad062247d3d186355fc863a124c2004ca45aafa Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 6 May 2026 16:07:59 +0200 Subject: [PATCH] loopback: handle stream setup failure Instead of silently failing. Also when we do the cleanup, make sure we don't free the props twice. --- src/modules/module-loopback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/module-loopback.c b/src/modules/module-loopback.c index 072f0a724..dc0e06d5f 100644 --- a/src/modules/module-loopback.c +++ b/src/modules/module-loopback.c @@ -1003,6 +1003,7 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) } pw_properties_free(props); + props = NULL; pw_proxy_add_listener((struct pw_proxy*)impl->core, &impl->core_proxy_listener, @@ -1011,7 +1012,8 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) &impl->core_listener, &core_events, impl); - setup_streams(impl); + if ((res = setup_streams(impl)) < 0) + goto error; pw_impl_module_add_listener(module, &impl->module_listener, &module_events, impl);