modules: handle factory destroy

Listen for factory destroy and clean up the module.

See #565
This commit is contained in:
Wim Taymans 2022-05-06 12:11:20 +02:00
parent 95f8c569a0
commit 383df85466
12 changed files with 264 additions and 90 deletions

View file

@ -51,12 +51,13 @@ static const struct spa_dict_item module_props[] = {
struct factory_data {
struct pw_context *context;
struct pw_impl_factory *this;
struct pw_impl_module *module;
struct spa_hook factory_listener;
struct pw_impl_module *module;
struct spa_hook module_listener;
struct pw_impl_factory *factory;
struct spa_hook factory_listener;
struct spa_list node_list;
};
@ -121,7 +122,7 @@ static void *create_object(void *_data,
goto error_properties;
pw_properties_setf(properties, PW_KEY_FACTORY_ID, "%d",
pw_global_get_id(pw_impl_factory_get_global(data->this)));
pw_global_get_id(pw_impl_factory_get_global(data->factory)));
linger = pw_properties_get_bool(properties, PW_KEY_OBJECT_LINGER, false);
@ -187,15 +188,17 @@ static const struct pw_impl_factory_implementation factory_impl = {
.create_object = create_object,
};
static void factory_destroy(void *_data)
static void factory_destroy(void *data)
{
struct factory_data *data = _data;
struct factory_data *d = data;
struct node_data *nd;
spa_hook_remove(&data->factory_listener);
spa_list_consume(nd, &data->node_list, link)
spa_hook_remove(&d->factory_listener);
spa_list_consume(nd, &d->node_list, link)
pw_impl_node_destroy(nd->node);
data->this = NULL;
d->factory = NULL;
if (d->module)
pw_impl_module_destroy(d->module);
}
static const struct pw_impl_factory_events factory_events = {
@ -203,19 +206,20 @@ static const struct pw_impl_factory_events factory_events = {
.destroy = factory_destroy,
};
static void module_destroy(void *_data)
static void module_destroy(void *data)
{
struct factory_data *data = _data;
spa_hook_remove(&data->module_listener);
if (data->this)
pw_impl_factory_destroy(data->this);
struct factory_data *d = data;
spa_hook_remove(&d->module_listener);
d->module = NULL;
if (d->factory)
pw_impl_factory_destroy(d->factory);
}
static void module_registered(void *data)
{
struct factory_data *d = data;
struct pw_impl_module *module = d->module;
struct pw_impl_factory *factory = d->this;
struct pw_impl_factory *factory = d->factory;
struct spa_dict_item items[1];
char id[16];
int res;
@ -254,7 +258,7 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args)
return -errno;
data = pw_impl_factory_get_user_data(factory);
data->this = factory;
data->factory = factory;
data->context = context;
data->module = module;
spa_list_init(&data->node_list);