mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-12-17 08:56:49 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

alsa: also set period size when using IRQ mode

Browse source 
Use the graph duration as the period size even when we are not using
a batch device.
This commit is contained in:
Wim Taymans 2023-04-10 16:07:24 +02:00
parent d59e1094cd
commit 30657abf28
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spa/plugins/alsa/alsa-pcm.c
View file

@ -1567,9 +1567,12 @@ int spa_alsa_set_format(struct state *state, struct spa_audio_info *fmt, uint32_
is_batch = snd_pcm_hw_params_is_batch(params) && is_batch = snd_pcm_hw_params_is_batch(params) &&
!state->disable_batch; !state->disable_batch;
/* no period size specified. If we are batch or not using timers,
* use the graph duration as the period */
if (period_size == 0 && (is_batch || state->disable_tsched))
period_size = state->position ? state->position->clock.duration : DEFAULT_PERIOD;
if (is_batch) { if (is_batch) {
if (period_size == 0)
period_size = state->position ? state->position->clock.duration : DEFAULT_PERIOD;
if (period_size == 0) if (period_size == 0)
period_size = DEFAULT_PERIOD; period_size = DEFAULT_PERIOD;
/* batch devices get their hw pointers updated every period. Make /* batch devices get their hw pointers updated every period. Make
@ -1617,17 +1620,18 @@ int spa_alsa_set_format(struct state *state, struct spa_audio_info *fmt, uint32_
state->headroom = state->default_headroom; state->headroom = state->default_headroom;
if (!state->disable_tsched) { if (!state->disable_tsched) {
/* If tsched is disabled, we know the pointers are updated when we wake /* When using timers, we might miss the pointer update for batch
* up, so we don't need the additional headroom */ * devices so add some extra headroom. With IRQ, we know the pointers
* are updated when we wake up and we don't need the headroom. */
if (is_batch) if (is_batch)
state->headroom += period_size; state->headroom += period_size;
/* add 32 extra samples of headroom to handle jitter in capture */ /* Add 32 extra samples of headroom to handle jitter in capture.
* For IRQ, we don't need this because when we wake up, we have
* exactly enough samples to read or write. */
if (state->stream == SND_PCM_STREAM_CAPTURE) if (state->stream == SND_PCM_STREAM_CAPTURE)
state->headroom = SPA_MAX(state->headroom, 32u); state->headroom = SPA_MAX(state->headroom, 32u);
} }
state->max_delay = state->buffer_frames / 2; state->max_delay = state->buffer_frames / 2;
if (spa_strstartswith(state->props.device, "a52") || if (spa_strstartswith(state->props.device, "a52") ||
spa_strstartswith(state->props.device, "dca")) spa_strstartswith(state->props.device, "dca"))