mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-31 22:25:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

audioconvert/fmtconvert: assume F32 on the other port when listing formats

Browse source 
This allows picking F32LE as the default format on links that have
no restriction and it avoids failing negotiation when the restricted
end cannot handle S16/F32/F32P

For instance this pipeline would previously fail:

  audio-dsp mode=merge ! audio-dsp mode=convert ! alsa-sink
old negotiation:     S16LE                   S24_32LE
new negotiation:     F32LE                   S24_32LE

The link between the audio-dsp nodes has no restriction, so previously
it would negotiate S16LE, which would then fail to negotiate with alsa-sink
because fmtconvert does not know how to convert S16LE to S24_32LE directly.

With this change, the middle link negotiates to F32LE, which can be
converted to anything.
This commit is contained in:
George Kiagiadakis 2019-07-29 16:12:45 +03:00 • committed by Wim Taymans
parent bf618c3440
commit 30576fcff8
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
spa/plugins/audioconvert/fmtconvert.c
View file

@ -336,7 +336,7 @@ static int port_enum_formats(void *object,
if (other->have_format)
info = other->format;
else
info.info.raw.format = SPA_AUDIO_FORMAT_S16;
info.info.raw.format = SPA_AUDIO_FORMAT_F32;
if (!other->have_format ||
info.info.raw.format == SPA_AUDIO_FORMAT_F32P ||