mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

context: handle link-group nodes

Browse source 
Nodes with the same link-group should be added to the same driver.

Also the runnable state of the nodes in the same link group is
shared between eachother. This makes it look like the linked nodes are
really just one big node.

With this change we correctly calculate the state of all nodes and we
can then only set the running state on the runnable nodes.

If you have 2 loopback sinks in front of a driver, this change will
only make the used loopback sink running and keep the other one
idle. It also works for grouped nodes, where only the active nodes
will now be running (such as rtp-session nodes).
This commit is contained in:
Wim Taymans 2023-03-09 08:53:29 +01:00
parent 93e6e98a17
commit 2bfe772bb4
1 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/pipewire/context.c
View file

@ -768,7 +768,8 @@ error:
static int ensure_state(struct pw_impl_node *node, bool running)
{
enum pw_node_state state = node->info.state;
if (node->active && !SPA_FLAG_IS_SET(node->spa_flags, SPA_NODE_FLAG_NEED_CONFIGURE) && running)
if (node->active && node->runnable &&
!SPA_FLAG_IS_SET(node->spa_flags, SPA_NODE_FLAG_NEED_CONFIGURE) && running)
state = PW_NODE_STATE_RUNNING;
else if (state > PW_NODE_STATE_IDLE)
state = PW_NODE_STATE_IDLE;
@ -842,6 +843,31 @@ static int collect_nodes(struct pw_context *context, struct pw_impl_node *node,
}
}
}
/* go through all the nodes that are linked together in some way.
* They inherit the runnable flag and are moved to the same driver. */
if (n->link_group != NULL) {
spa_list_for_each(t, &context->node_list, link) {
if (t->exported || !t->active)
continue;
/* don't care if our state won't change below. */
if ((t->runnable || !n->runnable) && t->visited)
continue;
if (!spa_streq(t->link_group, n->link_group))
continue;
/* All nodes from the same link group inherit the runnable
* flag. */
t->runnable |= n->runnable;
if (!t->visited) {
/* if we did not visit this node, add it to the same
* driver */
t->visited = true;
spa_list_append(&queue, &t->sort_link);
}
pw_log_debug("%p: %s join link group %s runnable:%u",
t, t->name, t->link_group, t->runnable);
}
}
/* now go through all the nodes that have the same group and
* that are not yet visited */
if (n->group != NULL) {