mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

dbus: keep a ref to DBusConnection if reconnecting is not handled

Browse source 
Several places in the code don't handle reconnecting DBus connections
yet. In those cases, a ref to the DBusConnection handle needs to be
kept, so that there's no use-after-free if it gets freed by spa_dbus
if the connection is broken.

Adjust spa_dbus so that others keeping additional refs is safe.
This commit is contained in:
Pauli Virtanen 2021-05-17 18:19:44 +03:00
parent cb6dbd165a
commit 2b515b5e50
6 changed files with 58 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

5
spa/include/spa/support/dbus.h
View file

@ -68,6 +68,11 @@ struct spa_dbus_connection {
/**
* Get the DBusConnection from a wrapper
*
* Note that the returned handle is closed and unref'd by spa_dbus
* immediately before emitting the asynchronous "disconnected" event.
* The caller must either deal with the invalidation, or keep an extra
* ref on the handle returned.
*
* \param conn the spa_dbus_connection wrapper
* \return a pointer of type DBusConnection
*/