From 2ad8904ac86767f0e57b220c194e8a5675e08326 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Thu, 14 Nov 2024 11:06:11 +0100 Subject: [PATCH] spa: update the UNPOSITIONED flag When we can't parse valid positions, make sure the UNPOSITIONED flag is set for raw audio info. --- spa/include/spa/param/audio/raw-json.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/spa/include/spa/param/audio/raw-json.h b/spa/include/spa/param/audio/raw-json.h index b718fd68f..f8608868f 100644 --- a/spa/include/spa/param/audio/raw-json.h +++ b/spa/include/spa/param/audio/raw-json.h @@ -52,8 +52,10 @@ spa_audio_info_raw_update(struct spa_audio_info_raw *info, const char *key, cons if (spa_atou32(val, &v, 0) && (force || info->channels == 0)) info->channels = SPA_MIN(v, SPA_AUDIO_MAX_CHANNELS); } else if (spa_streq(key, SPA_KEY_AUDIO_POSITION)) { - if (force || info->channels == 0) - spa_audio_parse_position(val, strlen(val), info->position, &info->channels); + if (force || info->channels == 0) { + if (spa_audio_parse_position(val, strlen(val), info->position, &info->channels) > 0) + SPA_FLAG_CLEAR(info->flags, SPA_AUDIO_FLAG_UNPOSITIONED); + } } return 0; } @@ -64,6 +66,7 @@ spa_audio_info_raw_init_dict_keys(struct spa_audio_info_raw *info, const struct spa_dict *dict, ...) { spa_zero(*info); + SPA_FLAG_SET(info->flags, SPA_AUDIO_FLAG_UNPOSITIONED); if (dict) { const char *val, *key; va_list args;