From 2922b0e10882c10c7f1a85bb74a4299f869176bc Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Fri, 1 Apr 2022 11:42:42 +0200 Subject: [PATCH] channelmix: make PSD the default again We can't have a default that simply copies channels, that's just wrong. So we enable PSD again. PSD does a good job of moving the ambient sound to the back. It's subtle and almost stereo like but it's better than plain stereo. The stereo widen has been reduced to make it more like the simple upmixing. People that previously wanted the copy-channels-experience had to manually enable this in pulseaudio so it's not too much to ask to manually switch the algoritm to simple. I think this is a better default. Fixes #861 See #2219 --- spa/plugins/audioconvert/channelmix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spa/plugins/audioconvert/channelmix.c b/spa/plugins/audioconvert/channelmix.c index 4a94fc1a1..98f69c18b 100644 --- a/spa/plugins/audioconvert/channelmix.c +++ b/spa/plugins/audioconvert/channelmix.c @@ -1655,12 +1655,12 @@ impl_init(const struct spa_handle_factory *factory, props_reset(&this->props); this->mix.options = CHANNELMIX_OPTION_UPMIX; - this->mix.upmix = CHANNELMIX_UPMIX_SIMPLE; + this->mix.upmix = CHANNELMIX_UPMIX_PSD; this->mix.log = this->log; this->mix.lfe_cutoff = 120.0f; this->mix.fc_cutoff = 6000.0f; this->mix.rear_delay = 12.0f; - this->mix.widen = 0.1f; + this->mix.widen = 0.02f; for (i = 0; info && i < info->n_items; i++) { const char *k = info->items[i].key;