mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-31 22:25:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

audioconvert: avoid bitfield data races

Browse source 
Move the driver and warned bits after the int field in the struct so
that they are placed in separate memory.

Otherwise, a write from the data thread might race with a write from the
main thread and leave the bits in the wrong state.
This commit is contained in:
Wim Taymans 2023-12-13 12:10:18 +01:00
parent 70b224f1c2
commit 27bed62e66
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
spa/plugins/audioconvert/audioadapter.c
View file

@ -89,13 +89,14 @@ struct impl {
unsigned int add_listener:1; unsigned int add_listener:1;
unsigned int have_format:1; unsigned int have_format:1;
unsigned int started:1; unsigned int started:1;
unsigned int warned:1;
unsigned int ready:1; unsigned int ready:1;
unsigned int driver:1;
unsigned int async:1; unsigned int async:1;
unsigned int passthrough:1; unsigned int passthrough:1;
unsigned int follower_removing:1; unsigned int follower_removing:1;
unsigned int in_recalc; unsigned int in_recalc;
unsigned int warned:1;
unsigned int driver:1;
}; };
/** \endcond */ /** \endcond */