mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluez5: probe adapter msbc capability via hci commands

Browse source 
Using a probe connection to determine adapter msbc capability causes
problems on some adapters (ff8c3d2, 84bc0490a5, 717004334b,
pipewire#2030) and seems to be a bad idea.

Go back to probing for transparent msbc transport capability via HCI
commands. bluetooth/hci.h may be deprecated later, but for now it's
better to go back to using it.  (In practice, adapters not supporting
esco appear to be fairly rare; kernel commit in 2013 refers to "older
devices", so if we can't use HCI, assume the adapter supports the
necessary modes.)
This commit is contained in:
Pauli Virtanen 2022-01-20 22:39:51 +02:00
parent 483831e514
commit 1da23145df
4 changed files with 120 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

93
spa/plugins/bluez5/hci.c Normal file
View file

@ -0,0 +1,93 @@
/* Spa HSP/HFP native backend HCI support
*
* Copyright © 2022 Pauli Virtanen
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include <errno.h>
#include <unistd.h>
#include <stdarg.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <poll.h>
#include <sys/uio.h>
#include <sys/socket.h>
#include "defs.h"
#ifndef HAVE_BLUEZ_5_HCI
int spa_bt_adapter_has_msbc(struct spa_bt_adapter *adapter)
{
if (adapter->msbc_probed)
return adapter->has_msbc;
return -EOPNOTSUPP;
}
#else
#include <bluetooth/bluetooth.h>
#include <bluetooth/hci.h>
#include <bluetooth/hci_lib.h>
int spa_bt_adapter_has_msbc(struct spa_bt_adapter *adapter)
{
int hci_id, res;
int sock = -1;
uint8_t features[8], max_page = 0;
struct sockaddr_hci a;
const char *str;
if (adapter->msbc_probed)
return adapter->has_msbc;
str = strrchr(adapter->path, '/'); /* hciXX */
if (str == NULL || sscanf(str, "/hci%d", &hci_id) != 1 || hci_id < 0)
return -ENOENT;
sock = socket(AF_BLUETOOTH, SOCK_RAW | SOCK_CLOEXEC, BTPROTO_HCI);
if (sock < 0)
goto error;
memset(&a, 0, sizeof(a));
a.hci_family = AF_BLUETOOTH;
a.hci_dev = hci_id;
if (bind(sock, (struct sockaddr *) &a, sizeof(a)) < 0)
goto error;
if (hci_read_local_ext_features(sock, 0, &max_page, features, 1000) < 0)
goto error;
close(sock);
adapter->msbc_probed = true;
adapter->has_msbc = ((features[2] & LMP_TRSP_SCO) && (features[3] & LMP_ESCO)) ? 1 : 0;
return adapter->has_msbc;
error:
res = -errno;
if (sock >= 0)
close(sock);
return res;
}
#endif