mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

link: deprectate using port.id in link-factory

Browse source 
It is ambiguous when the port.id also matches a port object.id.
This commit is contained in:
Wim Taymans 2025-02-14 11:19:54 +01:00
parent 152acf69c2
commit 1c9b5fd258
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/modules/module-link-factory.c
View file

@ -47,9 +47,9 @@
* specified.
* - `link.output.port`: The output port to link. This can be a port object.id, port.name,
* port.alias or object.path. If an output node is specified, the
* port must belong to the node and if no port was found using the
* object.id, port.name, port.alias or object.path, the port.id is
* used to find the port in the node. If no output port is given, an
* port must belong to the node. Finding a port in a node using the
* port.id is deprecated and may lead to unexpected results when the
* port.id also matches an object.id. If no output port is given, an
* output node must be specified and a random (unlinked) port will
* be used from the node.
* - `link.input.node`: The input node to use. This can be the node object.id, node.name,
@ -58,9 +58,9 @@
* specified.
* - `link.input.port`: The input port to link. This can be a port object.id, port.name,
* port.alias or object.path. If an input node is specified, the
* port must belong to the node and if no port was found using the
* object.id, port.name, port.alias or object.path, the port.id is
* used to find the port in the node. If no input port is given, an
* port must belong to the node. Finding a port in a node using the
* port.id is deprecated and may lead to unexpected results when the
* port.id also matches an object.id. If no input port is given, an
* input node must be specified and a random (unlinked) port will
* be used from the node.
* - `object.linger`: Keep the link around even when the client that created it is gone.
@ -380,7 +380,7 @@ static struct pw_impl_port *find_port(struct pw_context *context,
}
}
if (node != NULL) {
/* find port by local id */
/* find port by local id (deprecated) */
if (find.id != SPA_ID_INVALID) {
find.port = pw_impl_node_find_port(node, find.direction, find.id);
if (find.port != NULL)