mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-08 13:30:08 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pipewire: module-echo-cancel: aec-webrtc: use getters with default

Browse source 
Instead of get-check-parse, use `pw_properties_get_bool()`
which does all three in one convenient function.
This commit is contained in:
Barnabás Pőcze 2021-11-09 17:17:34 +01:00
parent 175efc4c1d
commit 144face6ad
1 changed files with 12 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

63
src/modules/module-echo-cancel/aec-webrtc.cpp
View file

@ -46,61 +46,22 @@ static void *webrtc_create(const struct pw_properties *args, const spa_audio_inf
webrtc::ProcessingConfig pconfig; webrtc::ProcessingConfig pconfig;
webrtc::Config config; webrtc::Config config;
const char* prop; bool extended_filter = pw_properties_get_bool(args, "webrtc.extended_filter", true);
bool extended_filter; bool delay_agnostic = pw_properties_get_bool(args, "webrtc.delay_agnostic", true);
bool delay_agnostic; bool high_pass_filter = pw_properties_get_bool(args, "webrtc.high_pass_filter", true);
bool high_pass_filter; bool noise_suppression = pw_properties_get_bool(args, "webrtc.noise_suppression", true);
bool noise_suppression;
bool gain_control; // Note: AGC seems to mess up with Agnostic Delay Detection, especially with speech,
bool experimental_agc; // result in very poor performance, disable by default
bool experimental_ns; bool gain_control = pw_properties_get_bool(args, "webrtc.gain_control", false);
bool intelligibility;
if ((prop = pw_properties_get(args, "webrtc.extended_filter")) != NULL) {
extended_filter = pw_properties_parse_bool(prop);
} else {
extended_filter = true;
}
if ((prop = pw_properties_get(args, "webrtc.delay_agnostic")) != NULL) {
delay_agnostic = pw_properties_parse_bool(prop);
} else {
delay_agnostic = true;
}
if ((prop = pw_properties_get(args, "webrtc.high_pass_filter")) != NULL) {
high_pass_filter = pw_properties_parse_bool(prop);
} else {
high_pass_filter = true;
}
if ((prop = pw_properties_get(args, "webrtc.noise_suppression")) != NULL) {
noise_suppression = pw_properties_parse_bool(prop);
} else {
noise_suppression = true;
}
if ((prop = pw_properties_get(args, "webrtc.gain_control")) != NULL) {
gain_control = pw_properties_parse_bool(prop);
} else {
// Note: AGC seems to mess up with Agnostic Delay Detection, especially with speech,
// result in very poor performance, disable by default
gain_control = false;
}
// Disable experimental flags by default // Disable experimental flags by default
if ((prop = pw_properties_get(args, "webrtc.experimental_agc")) != NULL) { bool experimental_agc = pw_properties_get_bool(args, "webrtc.experimental_agc", false);
experimental_agc = pw_properties_parse_bool(prop); bool experimental_ns = pw_properties_get_bool(args, "webrtc.experimental_ns", false);
} else {
experimental_agc = false;
}
if ((prop = pw_properties_get(args, "webrtc.experimental_ns")) != NULL) {
experimental_ns = pw_properties_parse_bool(prop);
} else {
experimental_ns = false;
}
// Intelligibility Enhancer will enforce an upmix on non-mono outputs // Intelligibility Enhancer will enforce an upmix on non-mono outputs
// Disable by default // Disable by default
if ((prop = pw_properties_get(args, "webrtc.intelligibility")) != NULL) { bool intelligibility = pw_properties_get_bool(args, "webrtc.intelligibility", false);
intelligibility = pw_properties_parse_bool(prop);
} else {
intelligibility = false;
}
config.Set<webrtc::ExtendedFilter>(new webrtc::ExtendedFilter(extended_filter)); config.Set<webrtc::ExtendedFilter>(new webrtc::ExtendedFilter(extended_filter));
config.Set<webrtc::DelayAgnostic>(new webrtc::DelayAgnostic(delay_agnostic)); config.Set<webrtc::DelayAgnostic>(new webrtc::DelayAgnostic(delay_agnostic));