From 0e0c325194a0bdb9fb007e34644b4e185744d3fc Mon Sep 17 00:00:00 2001
From: Wim Taymans <wtaymans@redhat.com>
Date: Wed, 8 Apr 2026 11:29:36 +0200
Subject: [PATCH] fix some uninitialized variables warnings

---
 src/modules/module-filter-chain.c                | 2 +-
 src/modules/module-protocol-pulse/pulse-server.c | 7 +++----
 src/modules/module-raop/rtsp-client.c            | 2 +-
 src/modules/module-sendspin/websocket.c          | 2 +-
 src/modules/module-snapcast-discover.c           | 2 +-
 src/pipewire/impl-module.c                       | 2 +-
 6 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c
index 97baa8f5f..b4e123985 100644
--- a/src/modules/module-filter-chain.c
+++ b/src/modules/module-filter-chain.c
@@ -1651,7 +1651,7 @@ static const struct pw_stream_events out_stream_events = {
 
 static int setup_streams(struct impl *impl)
 {
-	int res;
+	int res = 0;
 	uint32_t i, n_params, *offs, flags;
 	struct pw_array offsets;
 	const struct spa_pod **params = NULL;
diff --git a/src/modules/module-protocol-pulse/pulse-server.c b/src/modules/module-protocol-pulse/pulse-server.c
index 24251942a..2006a01cc 100644
--- a/src/modules/module-protocol-pulse/pulse-server.c
+++ b/src/modules/module-protocol-pulse/pulse-server.c
@@ -4750,7 +4750,6 @@ static int do_set_profile(struct client *client, uint32_t command, uint32_t tag,
 static int do_set_default(struct client *client, uint32_t command, uint32_t tag, struct message *m)
 {
 	struct pw_manager *manager = client->manager;
-	struct pw_manager_object *o;
 	const char *name, *str;
 	int res;
 	bool sink = command == COMMAND_SET_DEFAULT_SINK;
@@ -4767,10 +4766,10 @@ static int do_set_default(struct client *client, uint32_t command, uint32_t tag,
 	if (spa_streq(name, "@NONE@"))
 		name = NULL;
 
-	if (name != NULL && (o = find_device(client, SPA_ID_INVALID, name, sink, NULL)) == NULL)
-		return -ENOENT;
-
 	if (name != NULL) {
+		struct pw_manager_object *o;
+		if ((o = find_device(client, SPA_ID_INVALID, name, sink, NULL)) == NULL)
+			return -ENOENT;
 		if (o->props && (str = pw_properties_get(o->props, PW_KEY_NODE_NAME)) != NULL)
 			name = str;
 		else if (spa_strendswith(name, ".monitor"))
diff --git a/src/modules/module-raop/rtsp-client.c b/src/modules/module-raop/rtsp-client.c
index ee3ef43ae..4bcff8b88 100644
--- a/src/modules/module-raop/rtsp-client.c
+++ b/src/modules/module-raop/rtsp-client.c
@@ -481,7 +481,7 @@ int pw_rtsp_client_connect(struct pw_rtsp_client *client,
 {
 	struct addrinfo hints;
 	struct addrinfo *result, *rp;
-	int res, fd;
+	int res, fd = -1;
 	char port_str[12];
 
 	if (client->source != NULL)
diff --git a/src/modules/module-sendspin/websocket.c b/src/modules/module-sendspin/websocket.c
index 7deb57e89..5730a5c87 100644
--- a/src/modules/module-sendspin/websocket.c
+++ b/src/modules/module-sendspin/websocket.c
@@ -963,7 +963,7 @@ int pw_websocket_connect(struct pw_websocket *ws, void *user,
 {
 	struct addrinfo hints;
 	struct addrinfo *result, *rp;
-	int res, fd;
+	int res, fd = -1;
 	struct pw_websocket_connection *conn = NULL;
 
 	memset(&hints, 0, sizeof(hints));
diff --git a/src/modules/module-snapcast-discover.c b/src/modules/module-snapcast-discover.c
index 5fe2dedd9..5c7896bcf 100644
--- a/src/modules/module-snapcast-discover.c
+++ b/src/modules/module-snapcast-discover.c
@@ -416,7 +416,7 @@ static int snapcast_connect(struct tunnel *t)
 {
 	struct addrinfo hints;
 	struct addrinfo *result, *rp;
-	int res, fd;
+	int res, fd = -1;
 	char port_str[12];
 
 	if (t->server_address == NULL)
diff --git a/src/pipewire/impl-module.c b/src/pipewire/impl-module.c
index d670f883a..54db8f868 100644
--- a/src/pipewire/impl-module.c
+++ b/src/pipewire/impl-module.c
@@ -141,7 +141,7 @@ pw_context_load_module(struct pw_context *context,
 {
 	struct pw_impl_module *this;
 	struct impl *impl;
-	void *hnd;
+	void *hnd = NULL;
 	char *filename = NULL;
 	const char *module_dir;
 	int res;