From 0d0af4c9d8d7bcd4c0cf6b22e7c467d147235886 Mon Sep 17 00:00:00 2001 From: jdavidsson Date: Wed, 22 Mar 2023 11:47:04 +0100 Subject: [PATCH] module-echo-cancel: null check playback stream Protect against segfault when monitor.mode = true and playback stream isn't created. --- src/modules/module-echo-cancel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/module-echo-cancel.c b/src/modules/module-echo-cancel.c index 390fa3051..b0db1cc04 100644 --- a/src/modules/module-echo-cancel.c +++ b/src/modules/module-echo-cancel.c @@ -666,7 +666,8 @@ static void input_param_changed(void *data, uint32_t id, const struct spa_pod* p params[0] = get_props_param(impl, &b.b); if (params[0]) { pw_stream_update_params(impl->capture, params, 1); - pw_stream_update_params(impl->playback, params, 1); + if (impl->playback != NULL) + pw_stream_update_params(impl->playback, params, 1); } spa_pod_dynamic_builder_clean(&b); } else { @@ -767,7 +768,8 @@ static void output_param_changed(void *data, uint32_t id, const struct spa_pod * params[0] = get_props_param(impl, &b.b); if (params[0] != NULL) { pw_stream_update_params(impl->capture, params, 1); - pw_stream_update_params(impl->playback, params, 1); + if (impl->playback != NULL) + pw_stream_update_params(impl->playback, params, 1); } spa_pod_dynamic_builder_clean(&b); }