mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

module-rtp: Add some sender latency validation

Browse source 
Just a sanity check on config.
This commit is contained in:
Arun Raghavan 2024-01-29 12:09:14 -05:00 • committed by Wim Taymans
parent c6bae2742e
commit 0c37adb665
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/modules/module-rtp/stream.c
View file

@ -470,6 +470,9 @@ struct rtp_stream *rtp_stream_new(struct pw_core *core,
pw_properties_setf(props, "rtp.framecount", "%u", impl->psamples); pw_properties_setf(props, "rtp.framecount", "%u", impl->psamples);
} }
} }
ptime = samples_to_msec(impl, impl->psamples);
/* For senders, the default latency is ptime and for a receiver it is /* For senders, the default latency is ptime and for a receiver it is
* DEFAULT_SESS_LATENCY. Setting the sess.latency.msec for a sender to * DEFAULT_SESS_LATENCY. Setting the sess.latency.msec for a sender to
* something smaller/bigger will influence the quantum and the amount * something smaller/bigger will influence the quantum and the amount
@ -477,12 +480,23 @@ struct rtp_stream *rtp_stream_new(struct pw_core *core,
str = pw_properties_get(props, "sess.latency.msec"); str = pw_properties_get(props, "sess.latency.msec");
if (!spa_atof(str, &latency_msec)) { if (!spa_atof(str, &latency_msec)) {
latency_msec = direction == PW_DIRECTION_INPUT ? latency_msec = direction == PW_DIRECTION_INPUT ?
samples_to_msec(impl, impl->psamples) : ptime :
DEFAULT_SESS_LATENCY; DEFAULT_SESS_LATENCY;
} }
impl->target_buffer = msec_to_samples(impl, latency_msec); impl->target_buffer = msec_to_samples(impl, latency_msec);
impl->max_error = msec_to_samples(impl, ERROR_MSEC); impl->max_error = msec_to_samples(impl, ERROR_MSEC);
if (impl->target_buffer < ptime) {
pw_log_warn("sess.latency.msec cannot be lower than rtp.ptime");
impl->target_buffer = impl->psamples;
}
/* We're not expecting odd ptimes, so this modulo should be 0 */
if (fmodf(impl->target_buffer, ptime != 0)) {
pw_log_warn("sess.latency.msec should be an integer multiple of rtp.ptime");
impl->target_buffer = (impl->target_buffer / ptime) * impl->psamples;
}
pw_properties_setf(props, PW_KEY_NODE_RATE, "1/%d", impl->rate); pw_properties_setf(props, PW_KEY_NODE_RATE, "1/%d", impl->rate);
if (direction == PW_DIRECTION_INPUT) { if (direction == PW_DIRECTION_INPUT) {
pw_properties_setf(props, PW_KEY_NODE_LATENCY, "%d/%d", pw_properties_setf(props, PW_KEY_NODE_LATENCY, "%d/%d",