From 0c07c78621d3e34da87de9f7bce69ec26eb5f3c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sven=20P=C3=BCschel?= Date: Wed, 17 Jul 2024 14:19:12 +0200 Subject: [PATCH] spa: libcamera: uncomment setting integer controls MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When using Open Broadcaster Software with Pipewire and a libcamera camera node, changing the ExposureTime doesn't work. The commit introducing the camera control setting has commented out the integer case: ef4b9745b2fb ("libcamera: handle canceled requests") But as it doesn't give a reson for the comment, it looks like an oversight. Therefore removing the comment to allow setting the ExposureTime integer. Signed-off-by: Sven Püschel --- spa/plugins/libcamera/libcamera-utils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spa/plugins/libcamera/libcamera-utils.cpp b/spa/plugins/libcamera/libcamera-utils.cpp index 7cbe565c6..d28f22e1a 100644 --- a/spa/plugins/libcamera/libcamera-utils.cpp +++ b/spa/plugins/libcamera/libcamera-utils.cpp @@ -598,7 +598,7 @@ static int do_update_ctrls(struct spa_loop *loop, impl->ctrls.set(d->id, d->f_val); break; case ControlTypeInteger32: - //impl->ctrls.set(d->id, (int32_t)d->i_val); + impl->ctrls.set(d->id, (int32_t)d->i_val); break; default: break;