mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

spa: v4l2: Remove start_inotify() call from impl_on_fd_events()

Browse source 
The spa_loop_add_source() call for udev event monitoring which uses
impl_on_fd_events() is done from start_monitor() which also unconditionally
calls start_inotify().

Since start_monitor() already always calls start_inotify() there is no
scenario where start_inotify() has not been called yet when
impl_on_fd_events() gets called. So the start_inotify() call in
impl_on_fd_events() is redundant, remove it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
(cherry picked from commit ab245947e5)
This commit is contained in:
Hans de Goede 2024-09-09 14:53:14 +02:00 • committed by Robert Mader
parent dcf2d8f103
commit 0b54e568fa
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
spa/plugins/v4l2/v4l2-udev.c
View file

@ -495,8 +495,6 @@ static void impl_on_fd_events(struct spa_source *source)
spa_log_debug(this->log, "action %s", action); spa_log_debug(this->log, "action %s", action);
start_inotify(this);
if (spa_streq(action, "add") || if (spa_streq(action, "add") ||
spa_streq(action, "change")) { spa_streq(action, "change")) {
process_udev_device(this, ACTION_CHANGE, dev); process_udev_device(this, ACTION_CHANGE, dev);