mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-06-30 13:14:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

gst: deviceprovider: tear down node proxies before releasing core

Browse source 
Destroy the bound node proxies in probe() and stop() while the loop is
locked, before releasing the core. This removes the node listeners so no
node_event_info can fire after the core is gone, fixing the root cause of
the resync() NULL-deref crash and a node-proxy leak.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Torkel Niklasson 2026-06-29 10:36:33 +02:00 • committed by Wim Taymans
parent 7ee2416bdd
commit 0a413c866c
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/gst/gstpipewiredeviceprovider.c
View file

@ -502,6 +502,14 @@ static const struct pw_proxy_events proxy_node_events = {
.destroy = destroy_node,
};
static void clear_nodes(GstPipeWireDeviceProvider *self)
{
struct node_data *nd;
spa_list_consume(nd, &self->nodes, link)
pw_proxy_destroy((struct pw_proxy *)nd->proxy);
}
static void
removed_port (void *data)
{
@ -792,6 +800,7 @@ gst_pipewire_device_provider_probe (GstDeviceProvider * provider)
GST_DEBUG_OBJECT (self, "disconnect");
g_clear_pointer ((struct pw_proxy**)&self->registry, pw_proxy_destroy);
clear_nodes (self);
spa_hook_remove (&self->core_listener);
pw_thread_loop_unlock (self->core->loop);
g_clear_pointer (&self->core, gst_pipewire_core_release);
@ -867,6 +876,7 @@ gst_pipewire_device_provider_stop (GstDeviceProvider * provider)
g_clear_pointer ((struct pw_proxy**)&self->registry, pw_proxy_destroy);
if (self->core != NULL) {
clear_nodes (self);
spa_hook_remove (&self->core_listener);
pw_thread_loop_unlock (self->core->loop);
}