mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-31 22:25:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

spa: libcamera: remove unnecessary have_config member

Browse source 
An extra flag is not needed because the `config` pointer can be
checked to determine if a configuration has already been retrieved.
This commit is contained in:
Barnabás Pőcze 2022-09-04 03:48:51 +02:00 • committed by Wim Taymans
parent 9374c15c3d
commit 02f2d6b48d
2 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
spa/plugins/libcamera/libcamera-source.cpp
View file

@ -171,7 +171,6 @@ typedef struct impl {
void requestComplete(libcamera::Request *request); void requestComplete(libcamera::Request *request);
unsigned int have_config;
std::unique_ptr<CameraConfiguration> config; std::unique_ptr<CameraConfiguration> config;
struct spa_source source = {}; struct spa_source source = {};

3
spa/plugins/libcamera/libcamera-utils.cpp
View file

@ -69,13 +69,12 @@ int spa_libcamera_close(struct impl *impl)
static void spa_libcamera_get_config(struct impl *impl) static void spa_libcamera_get_config(struct impl *impl)
{ {
if (impl->have_config) if (impl->config)
return; return;
StreamRoles roles; StreamRoles roles;
roles.push_back(VideoRecording); roles.push_back(VideoRecording);
impl->config = impl->camera->generateConfiguration(roles); impl->config = impl->camera->generateConfiguration(roles);
impl->have_config = true;
} }
static int spa_libcamera_buffer_recycle(struct impl *impl, struct port *port, uint32_t buffer_id) static int spa_libcamera_buffer_recycle(struct impl *impl, struct port *port, uint32_t buffer_id)