mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

stream: don't set inactive on cork

Browse source 
We don't pause our clock ticks in the corked state which confuses
the timing code. As a workaround for now, don't set the node to
inactive when corked, this still keeps calling into the process
function and keep things moving. VLC seems to recover better.
This commit is contained in:
Wim Taymans 2020-01-17 15:34:31 +01:00
parent 1c46dc32f8
commit 0237296400
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pipewire-pulseaudio/src/stream.c
View file

@ -1537,8 +1537,8 @@ pa_operation* pa_stream_cork(pa_stream *s, int b, pa_stream_success_cb_t cb, voi
PA_CHECK_VALIDITY_RETURN_NULL(s->context, s->direction != PA_STREAM_UPLOAD, PA_ERR_BADSTATE);
s->corked = b;
pw_stream_set_active(s->stream, !b);
if (!b)
pw_stream_set_active(s->stream, true);
o = pa_operation_new(s->context, s, on_success, sizeof(struct success_ack));
d = o->userdata;
d->cb = cb;

5
src/pipewire/stream.c
View file

@ -1417,9 +1417,6 @@ pw_stream_connect(struct pw_stream *stream,
pw_impl_node_set_implementation(slave, &impl->impl_node);
if (!SPA_FLAG_IS_SET(impl->flags, PW_STREAM_FLAG_INACTIVE))
pw_impl_node_set_active(slave, true);
if (impl->media_type == SPA_MEDIA_TYPE_audio &&
impl->media_subtype == SPA_MEDIA_SUBTYPE_raw) {
factory = pw_context_find_factory(impl->context, "adapter");
@ -1442,6 +1439,8 @@ pw_stream_connect(struct pw_stream *stream,
} else {
impl->node = slave;
}
if (!SPA_FLAG_IS_SET(impl->flags, PW_STREAM_FLAG_INACTIVE))
pw_impl_node_set_active(impl->node, true);
pw_log_debug(NAME" %p: export node %p", stream, impl->node);
stream->proxy = pw_core_export(stream->core,