mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: add a test for the properties stack overflow

Browse source 
See #1249
This commit is contained in:
Peter Hutterer 2021-06-08 13:43:57 +10:00
parent 7240058bee
commit 008195924c
1 changed files with 35 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

35
test/test-properties.c
View file

@ -238,6 +238,40 @@ PWTEST(properties_update_string)
return PWTEST_PASS; return PWTEST_PASS;
} }
PWTEST(properties_serialize_dict_stack_overflow)
{
char *long_value = NULL;
struct spa_dict_item items[2];
struct spa_dict dict;
const int sz = 8 * 1024 * 1024;
char tmpfile[PATH_MAX];
FILE *fp;
int r;
/* Alloc a property value long enough to trigger a stack overflow
* in any variadic arrays (see * e994949d576e93f8c22)
*/
long_value = calloc(1, sz);
if (long_value == 0)
return PWTEST_SKIP;
memset(long_value, 'a', sz - 1);
items[0] = SPA_DICT_ITEM_INIT("longval", long_value);
items[1] = SPA_DICT_ITEM_INIT(long_value, "longval");
dict = SPA_DICT_INIT(items, 2);
pwtest_mkstemp(tmpfile);
fp = fopen(tmpfile, "w");
pwtest_ptr_notnull(fp);
r = pw_properties_serialize_dict(fp, &dict, 0);
pwtest_int_eq(r, 2);
fclose(fp);
free(long_value);
return PWTEST_PASS;
}
PWTEST_SUITE(properties) PWTEST_SUITE(properties)
{ {
pwtest_add(properties_new, PWTEST_NOARG); pwtest_add(properties_new, PWTEST_NOARG);
@ -248,6 +282,7 @@ PWTEST_SUITE(properties)
pwtest_add(properties_parse_int, PWTEST_NOARG); pwtest_add(properties_parse_int, PWTEST_NOARG);
pwtest_add(properties_copy, PWTEST_NOARG); pwtest_add(properties_copy, PWTEST_NOARG);
pwtest_add(properties_update_string, PWTEST_NOARG); pwtest_add(properties_update_string, PWTEST_NOARG);
pwtest_add(properties_serialize_dict_stack_overflow, PWTEST_NOARG);
return PWTEST_PASS; return PWTEST_PASS;
} }