Commit graph

3 commits

Author SHA1 Message Date
squassina
5597a5ab80 security: fix command execution and null-termination issues
Closes security vulnerabilities and documentation gaps:

1. Remove shell expansion from config-driven exec/exec-once
   - Eliminate wordexp() usage in spawn()
   - Add split_argv_noexpand() for safe argument parsing
   - Change run_exec() and run_exec_once() to use spawn() instead of spawn_shell()
   - Prevents shell injection and expansion-based DoS

2. Fix null-termination in chvt_backup_selmon
   - Add explicit null-terminator after strncpy() in chvt()
   - Prevents out-of-bounds read when used in regex_match()

3. Add regression test
   - New test_chvt_backup_selmon unit test to verify null-termination logic
   - Integrate tests into meson.build

4. Translate Chinese comments to English
   - Update IMPLEMENTATION_SUMMARY.md to remove Chinese text
   - Improves accessibility for international contributors

5. Update documentation
   - Update REVIEW_FINDINGS.md with English versions of examples
   - Remove wordexp include from meson.c headers (no longer needed)
2026-03-01 07:46:06 -03:00
copilot-swe-agent[bot]
8a7fa8dce2 Fix markdown linting errors in documentation files
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-19 13:35:16 +00:00
copilot-swe-agent[bot]
d344ab8a17 Add implementation summary and mark recommendations as completed
Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
2026-02-19 10:54:31 +00:00