From c6dbb4b1d62b79b736ff2ed07fa58a0a8cbb8321 Mon Sep 17 00:00:00 2001
From: cheerfulScumbag <164391367+cheerfulScumbag@users.noreply.github.com>
Date: Thu, 14 May 2026 21:39:49 +0100
Subject: [PATCH] cleanup: replace session buffer magic numbers

---
 src/mango.c           |  6 +++---
 src/session/session.h | 10 +++++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/mango.c b/src/mango.c
index 8b13f205..00da9412 100644
--- a/src/mango.c
+++ b/src/mango.c
@@ -81,6 +81,7 @@
 #include <wlr/types/wlr_virtual_pointer_v1.h>
 #include <wlr/types/wlr_xcursor_manager.h>
 #include <wlr/types/wlr_xdg_activation_v1.h>
+#include "session/session.h"
 #include <wlr/types/wlr_xdg_decoration_v1.h>
 #include <wlr/types/wlr_xdg_foreign_registry.h>
 #include <wlr/types/wlr_xdg_foreign_v1.h>
@@ -419,7 +420,7 @@ struct Client {
 	float focused_opacity;
 	float unfocused_opacity;
 	char oldmonname[128];
-	char session_launch_command[1024];
+	char session_launch_command[SESSION_COMMAND_MAX];
 	int32_t noblur;
 	double master_mfact_per, master_inner_per, stack_inner_per;
 	double old_master_mfact_per, old_master_inner_per, old_stack_inner_per;
@@ -626,7 +627,7 @@ typedef struct {
 	struct wl_list link;
 	pid_t pid;
 	time_t created_at;
-	char command[1024];
+	char command[SESSION_COMMAND_MAX];
 } SessionSpawnCommand;
 
 /* function declarations */
@@ -1051,7 +1052,6 @@ struct Pertag {
 	struct TagScrollerState *scroller_state[LENGTH(tags) + 1];
 };
 #include "config/parse_config.h"
-#include "session/session.h"
 
 static struct wl_signal mango_print_status;
 
diff --git a/src/session/session.h b/src/session/session.h
index 7306cad9..617af1e5 100644
--- a/src/session/session.h
+++ b/src/session/session.h
@@ -6,6 +6,10 @@
 
 typedef struct Client Client;
 
+#define SESSION_TITLE_MAX 512
+#define SESSION_MONITOR_MAX 128
+#define SESSION_COMMAND_MAX 1024
+
 typedef struct {
 	int32_t x;
 	int32_t y;
@@ -15,9 +19,9 @@ typedef struct {
 
 typedef struct {
 	char app_id[256];
-	char title[512];
-	char monitor[128];
-	char launch_command[1024];
+	char title[SESSION_TITLE_MAX];
+	char monitor[SESSION_MONITOR_MAX];
+	char launch_command[SESSION_COMMAND_MAX];
 	int32_t pid;
 	uint32_t tags;
 	int32_t is_floating;