mirrors/maomaowm
1
0
Fork 0
mirror of https://github.com/DreamMaoMao/maomaowm.git synced 2026-07-02 00:06:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Polish security fixes with minor improvements

Browse source 
- Remove redundant null termination for short strings
- Use descriptive variable names in cleanup loop
- Cache strlen results to avoid O(n²) complexity in string concatenation
- Add bounds checks before string operations

Co-authored-by: squassina <8495707+squassina@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-02-18 09:00:02 +00:00
parent e2649dd84f
commit 12fe0abca1
3 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/config/parse_config.h
View file

@ -598,11 +598,16 @@ static char *combine_args_until_empty(char *values[], int count) {
}
combined[0] = '\0';
size_t current_len = 0;
for (int i = 0; i < first_empty; i++) {
if (i > 0) {
strncat(combined, ",", total_len - strlen(combined));
if (i > 0 && current_len < total_len) {
strncat(combined, ",", total_len - current_len);
current_len = strlen(combined);
}
if (current_len < total_len) {
strncat(combined, values[i], total_len - current_len);
current_len = strlen(combined);
}
strncat(combined, values[i], total_len - strlen(combined));
}
return combined;