mirror of
https://github.com/labwc/labwc.git
synced 2025-11-04 13:30:07 -05:00
0b34b9f69f
Currently, we anchor the right/bottom edge of the view whenever the top/ left edge is moving (current.x/y != pending.x/y). Doing so doesn't make much sense when the right/bottom edge is also moving. In that case it's probably best to move the view (or at least its top/left corner) directly to its final position. The most noticeable effect of this change is with views that don't accept their requested size exactly when tiled or maximized (examples: havoc, xfce4-terminal). Previously, their right-bottom corner would be aligned with the screen edge, leaving gaps on the left and top. Now the top-left corner will be aligned and the gaps will be on the right and bottom. This is still not ideal, but IMHO less surprising to the user.
79 lines
2.2 KiB
C
79 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/* view-impl-common.c: common code for shell view->impl functions */
|
|
#include <stdio.h>
|
|
#include <strings.h>
|
|
#include "labwc.h"
|
|
#include "view.h"
|
|
#include "view-impl-common.h"
|
|
|
|
void
|
|
view_impl_move_to_front(struct view *view)
|
|
{
|
|
wl_list_remove(&view->link);
|
|
wl_list_insert(&view->server->views, &view->link);
|
|
wlr_scene_node_raise_to_top(&view->scene_tree->node);
|
|
}
|
|
|
|
void
|
|
view_impl_map(struct view *view)
|
|
{
|
|
desktop_focus_and_activate_view(&view->server->seat, view);
|
|
desktop_move_to_front(view);
|
|
view_update_title(view);
|
|
view_update_app_id(view);
|
|
}
|
|
|
|
static bool
|
|
resizing_edge(struct view *view, uint32_t edge)
|
|
{
|
|
struct server *server = view->server;
|
|
return server->input_mode == LAB_INPUT_STATE_RESIZE
|
|
&& server->grabbed_view == view
|
|
&& (server->resize_edges & edge);
|
|
}
|
|
|
|
void
|
|
view_impl_apply_geometry(struct view *view, int w, int h)
|
|
{
|
|
struct wlr_box *current = &view->current;
|
|
struct wlr_box *pending = &view->pending;
|
|
struct wlr_box old = *current;
|
|
|
|
/*
|
|
* Anchor right edge if resizing via left edge.
|
|
*
|
|
* Note that answering the question "are we resizing?" is a bit
|
|
* tricky. The most obvious method is to look at the server
|
|
* flags; but that method will not account for any late commits
|
|
* that occur after the mouse button is released, as the client
|
|
* catches up with pending configure requests. So as a fallback,
|
|
* we resort to a geometry-based heuristic -- also not 100%
|
|
* reliable on its own. The combination of the two methods
|
|
* should catch 99% of resize cases that we care about.
|
|
*/
|
|
bool resizing_left_edge = resizing_edge(view, WLR_EDGE_LEFT);
|
|
if (resizing_left_edge || (current->x != pending->x
|
|
&& current->x + current->width ==
|
|
pending->x + pending->width)) {
|
|
current->x = pending->x + pending->width - w;
|
|
} else {
|
|
current->x = pending->x;
|
|
}
|
|
|
|
/* Anchor bottom edge if resizing via top edge */
|
|
bool resizing_top_edge = resizing_edge(view, WLR_EDGE_TOP);
|
|
if (resizing_top_edge || (current->y != pending->y
|
|
&& current->y + current->height ==
|
|
pending->y + pending->height)) {
|
|
current->y = pending->y + pending->height - h;
|
|
} else {
|
|
current->y = pending->y;
|
|
}
|
|
|
|
current->width = w;
|
|
current->height = h;
|
|
|
|
if (!wlr_box_equal(current, &old)) {
|
|
view_moved(view);
|
|
}
|
|
}
|