mirror of
https://github.com/labwc/labwc.git
synced 2025-11-02 09:01:47 -05:00
Handlers for the "destroy" signal need to unregister themselves from the
signal (using wl_list_remove()) before invoking free().
Invalid write of size 8
at 0x487DF27: wl_list_remove (in /usr/lib/libwayland-server.so.0.20.0)
by 0x4906FF0: wlr_signal_emit_safe (signal.c:32)
by 0x48EA304: reset_xdg_surface (wlr_xdg_surface.c:430)
by 0x48EA3D6: UnknownInlinedFun (wlr_xdg_surface.c:464)
by 0x48EA3D6: xdg_surface_handle_resource_destroy (wlr_xdg_surface.c:282)
by 0x4877899: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487DEBF: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487E3DF: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487830D: wl_client_destroy (in /usr/lib/libwayland-server.so.0.20.0)
by 0x48783F6: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487B1C9: wl_event_loop_dispatch (in /usr/lib/libwayland-server.so.0.20.0)
by 0x4878D36: wl_display_run (in /usr/lib/libwayland-server.so.0.20.0)
by 0x110DAC: main (main.c:81)
Address 0xc3213d8 is 424 bytes inside a block of size 704 free'd
at 0x484118B: free (vg_replace_malloc.c:755)
by 0x4906FDD: wlr_signal_emit_safe (signal.c:29)
by 0x48EA304: reset_xdg_surface (wlr_xdg_surface.c:430)
by 0x48EA3D6: UnknownInlinedFun (wlr_xdg_surface.c:464)
by 0x48EA3D6: xdg_surface_handle_resource_destroy (wlr_xdg_surface.c:282)
by 0x4877899: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487DEBF: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487E3DF: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487830D: wl_client_destroy (in /usr/lib/libwayland-server.so.0.20.0)
by 0x48783F6: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487B1C9: wl_event_loop_dispatch (in /usr/lib/libwayland-server.so.0.20.0)
by 0x4878D36: wl_display_run (in /usr/lib/libwayland-server.so.0.20.0)
by 0x110DAC: main (main.c:81)
Block was alloc'd at
at 0x48435FF: calloc (vg_replace_malloc.c:1117)
by 0x113E22: xdg_surface_new (xdg.c:401)
by 0x4906FDD: wlr_signal_emit_safe (signal.c:29)
by 0x48EABE7: handle_xdg_surface_commit (wlr_xdg_surface.c:331)
by 0x4908FE7: surface_commit_state (wlr_surface.c:457)
by 0x524DD49: ??? (in /usr/lib/libffi.so.8.1.0)
by 0x524D266: ??? (in /usr/lib/libffi.so.8.1.0)
by 0x487D322: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x48785CB: ??? (in /usr/lib/libwayland-server.so.0.20.0)
by 0x487B1C9: wl_event_loop_dispatch (in /usr/lib/libwayland-server.so.0.20.0)
by 0x4878D36: wl_display_run (in /usr/lib/libwayland-server.so.0.20.0)
by 0x110DAC: main (main.c:81)
Invalid write of size 8
at 0x487DF27: wl_list_remove (in /usr/lib/libwayland-server.so.0.20.0)
by 0x4906FF0: wlr_signal_emit_safe (signal.c:32)
by 0x48F5529: UnknownInlinedFun (wlr_input_device.c:34)
by 0x48F5529: wlr_input_device_destroy (wlr_input_device.c:29)
by 0x48CE4B5: backend_destroy.part.0.lto_priv.0 (backend.c:148)
by 0x48D2D55: multi_backend_destroy (backend.c:59)
by 0x48788FE: wl_display_destroy (in /usr/lib/libwayland-server.so.0.20.0)
by 0x110E71: UnknownInlinedFun (server.c:406)
by 0x110E71: main (main.c:83)
Address 0xc466568 is 24 bytes inside a block of size 56 free'd
at 0x484118B: free (vg_replace_malloc.c:755)
by 0x4906FDD: wlr_signal_emit_safe (signal.c:29)
by 0x48F5529: UnknownInlinedFun (wlr_input_device.c:34)
by 0x48F5529: wlr_input_device_destroy (wlr_input_device.c:29)
by 0x48CE4B5: backend_destroy.part.0.lto_priv.0 (backend.c:148)
by 0x48D2D55: multi_backend_destroy (backend.c:59)
by 0x48788FE: wl_display_destroy (in /usr/lib/libwayland-server.so.0.20.0)
by 0x110E71: UnknownInlinedFun (server.c:406)
by 0x110E71: main (main.c:83)
Block was alloc'd at
at 0x48435FF: calloc (vg_replace_malloc.c:1117)
by 0x11590F: new_input_notify (seat.c:137)
by 0x4906FDD: wlr_signal_emit_safe (signal.c:29)
by 0x4906FDD: wlr_signal_emit_safe (signal.c:29)
by 0x48CDCEE: UnknownInlinedFun (events.c:109)
by 0x48CDCEE: UnknownInlinedFun (events.c:242)
by 0x48CDCEE: UnknownInlinedFun (backend.c:58)
by 0x48CDCEE: handle_libinput_readable (backend.c:48)
by 0x48CE1BE: backend_start.lto_priv.0 (backend.c:114)
by 0x48D2CE5: multi_backend_start (backend.c:33)
by 0x110C45: UnknownInlinedFun (server.c:375)
by 0x110C45: main (main.c:68)
439 lines
12 KiB
C
439 lines
12 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
#include <assert.h>
|
|
#include "labwc.h"
|
|
#include "ssd.h"
|
|
|
|
/*
|
|
* xdg_popup_create() and view_subsurface_create() are only called for the
|
|
* purposes of tracking damage.
|
|
*/
|
|
static void
|
|
handle_new_xdg_popup(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, new_popup);
|
|
struct wlr_xdg_popup *wlr_popup = data;
|
|
xdg_popup_create(view, wlr_popup);
|
|
}
|
|
|
|
static void
|
|
new_subsurface_notify(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, new_subsurface);
|
|
struct wlr_subsurface *wlr_subsurface = data;
|
|
view_subsurface_create(view, wlr_subsurface);
|
|
}
|
|
|
|
static bool
|
|
has_ssd(struct view *view)
|
|
{
|
|
if (!rc.xdg_shell_server_side_deco) {
|
|
return false;
|
|
}
|
|
|
|
/*
|
|
* Some XDG shells refuse to disable CSD in which case their
|
|
* geometry.{x,y} seems to be greater than zero. We filter on that
|
|
* on the assumption that this will remain true.
|
|
*/
|
|
if (view->xdg_surface->current.geometry.x || view->xdg_surface->current.geometry.y) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static void
|
|
handle_commit(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, commit);
|
|
assert(view->surface);
|
|
struct wlr_box size;
|
|
wlr_xdg_surface_get_geometry(view->xdg_surface, &size);
|
|
|
|
view->w = size.width;
|
|
view->h = size.height;
|
|
|
|
/* padding changes with maximize/unmaximize */
|
|
view->padding.top = view->padding.bottom = size.y;
|
|
view->padding.left = view->padding.right = size.x;
|
|
|
|
uint32_t serial = view->pending_move_resize.configure_serial;
|
|
if (serial > 0 && serial >= view->xdg_surface->current.configure_serial) {
|
|
if (view->pending_move_resize.update_x) {
|
|
view->x = view->pending_move_resize.x +
|
|
view->pending_move_resize.width - size.width;
|
|
}
|
|
if (view->pending_move_resize.update_y) {
|
|
view->y = view->pending_move_resize.y +
|
|
view->pending_move_resize.height - size.height;
|
|
}
|
|
if (serial == view->xdg_surface->current.configure_serial) {
|
|
view->pending_move_resize.configure_serial = 0;
|
|
}
|
|
}
|
|
ssd_update_geometry(view, false);
|
|
damage_view_part(view);
|
|
}
|
|
|
|
static void
|
|
handle_map(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, map);
|
|
view->impl->map(view);
|
|
}
|
|
|
|
static void
|
|
handle_unmap(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, unmap);
|
|
view->impl->unmap(view);
|
|
}
|
|
|
|
static void
|
|
handle_destroy(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, destroy);
|
|
if (view->toplevel_handle) {
|
|
wlr_foreign_toplevel_handle_v1_destroy(view->toplevel_handle);
|
|
}
|
|
interactive_end(view);
|
|
wl_list_remove(&view->link);
|
|
wl_list_remove(&view->destroy.link);
|
|
ssd_destroy(view);
|
|
free(view);
|
|
}
|
|
|
|
static void
|
|
handle_request_move(struct wl_listener *listener, void *data)
|
|
{
|
|
/*
|
|
* This event is raised when a client would like to begin an interactive
|
|
* move, typically because the user clicked on their client-side
|
|
* decorations. Note that a more sophisticated compositor should check
|
|
* the provied serial against a list of button press serials sent to
|
|
* this
|
|
* client, to prevent the client from requesting this whenever they
|
|
* want.
|
|
*/
|
|
struct view *view = wl_container_of(listener, view, request_move);
|
|
interactive_begin(view, LAB_INPUT_STATE_MOVE, 0);
|
|
}
|
|
|
|
static void
|
|
handle_request_resize(struct wl_listener *listener, void *data)
|
|
{
|
|
/*
|
|
* This event is raised when a client would like to begin an interactive
|
|
* resize, typically because the user clicked on their client-side
|
|
* decorations. Note that a more sophisticated compositor should check
|
|
* the provied serial against a list of button press serials sent to
|
|
* this
|
|
* client, to prevent the client from requesting this whenever they
|
|
* want.
|
|
*/
|
|
struct wlr_xdg_toplevel_resize_event *event = data;
|
|
struct view *view = wl_container_of(listener, view, request_resize);
|
|
interactive_begin(view, LAB_INPUT_STATE_RESIZE, event->edges);
|
|
}
|
|
|
|
static void
|
|
handle_request_maximize(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, request_maximize);
|
|
struct wlr_xdg_surface *surface = data;
|
|
if (view) {
|
|
view_maximize(view, surface->toplevel->requested.maximized);
|
|
}
|
|
|
|
}
|
|
|
|
static void
|
|
handle_request_fullscreen(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, request_fullscreen);
|
|
struct wlr_xdg_toplevel_set_fullscreen_event *e = data;
|
|
view_set_fullscreen(view, e->fullscreen, e->output);
|
|
}
|
|
|
|
static void
|
|
handle_set_title(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, set_title);
|
|
assert(view);
|
|
view_update_title(view);
|
|
}
|
|
|
|
static void
|
|
handle_set_app_id(struct wl_listener *listener, void *data)
|
|
{
|
|
struct view *view = wl_container_of(listener, view, set_app_id);
|
|
assert(view);
|
|
view_update_app_id(view);
|
|
}
|
|
|
|
#define MAX(a, b) (((a) > (b)) ? (a) : (b))
|
|
static void
|
|
xdg_toplevel_view_configure(struct view *view, struct wlr_box geo)
|
|
{
|
|
int min_width, min_height;
|
|
view_min_size(view, &min_width, &min_height);
|
|
|
|
view->pending_move_resize.update_x = geo.x != view->x;
|
|
view->pending_move_resize.update_y = geo.y != view->y;
|
|
view->pending_move_resize.x = geo.x;
|
|
view->pending_move_resize.y = geo.y;
|
|
view->pending_move_resize.width = MAX(geo.width, min_width);
|
|
view->pending_move_resize.height = MAX(geo.height, min_height);
|
|
|
|
uint32_t serial = wlr_xdg_toplevel_set_size(view->xdg_surface,
|
|
(uint32_t)geo.width, (uint32_t)geo.height);
|
|
if (serial > 0) {
|
|
view->pending_move_resize.configure_serial = serial;
|
|
} else if (view->pending_move_resize.configure_serial == 0) {
|
|
view->x = geo.x;
|
|
view->y = geo.y;
|
|
ssd_update_geometry(view, false);
|
|
damage_all_outputs(view->server);
|
|
}
|
|
}
|
|
#undef MAX
|
|
|
|
static void
|
|
xdg_toplevel_view_move(struct view *view, double x, double y)
|
|
{
|
|
view->x = x;
|
|
view->y = y;
|
|
ssd_update_geometry(view, false);
|
|
damage_all_outputs(view->server);
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_close(struct view *view)
|
|
{
|
|
wlr_xdg_toplevel_send_close(view->xdg_surface);
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_for_each_popup_surface(struct view *view,
|
|
wlr_surface_iterator_func_t iterator, void *data)
|
|
{
|
|
wlr_xdg_surface_for_each_popup_surface(view->xdg_surface, iterator, data);
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_for_each_surface(struct view *view,
|
|
wlr_surface_iterator_func_t iterator, void *data)
|
|
{
|
|
wlr_xdg_surface_for_each_surface(view->xdg_surface, iterator, data);
|
|
}
|
|
|
|
static void
|
|
update_padding(struct view *view)
|
|
{
|
|
struct wlr_box padding;
|
|
wlr_xdg_surface_get_geometry(view->xdg_surface, &padding);
|
|
view->padding.top = view->padding.bottom = padding.y;
|
|
view->padding.left = view->padding.right = padding.x;
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_maximize(struct view *view, bool maximized)
|
|
{
|
|
wlr_xdg_toplevel_set_maximized(view->xdg_surface, maximized);
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_set_activated(struct view *view, bool activated)
|
|
{
|
|
struct wlr_xdg_surface *surface = view->xdg_surface;
|
|
if (surface->role == WLR_XDG_SURFACE_ROLE_TOPLEVEL) {
|
|
wlr_xdg_toplevel_set_activated(surface, activated);
|
|
}
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_set_fullscreen(struct view *view, bool fullscreen)
|
|
{
|
|
wlr_xdg_toplevel_set_fullscreen(view->xdg_surface, fullscreen);
|
|
}
|
|
|
|
static bool
|
|
istopmost(struct view *view)
|
|
{
|
|
return view->xdg_surface->toplevel->parent == NULL;
|
|
}
|
|
|
|
static struct view *
|
|
parent_of(struct view *view)
|
|
{
|
|
struct view *p;
|
|
wl_list_for_each (p, &view->server->views, link) {
|
|
if (p->xdg_surface == view->xdg_surface->toplevel->parent) {
|
|
return p;
|
|
}
|
|
}
|
|
return NULL;
|
|
}
|
|
|
|
static void
|
|
position_xdg_toplevel_view(struct view *view)
|
|
{
|
|
if (istopmost(view)) {
|
|
struct wlr_box box =
|
|
output_usable_area_from_cursor_coords(view->server);
|
|
view->x = box.x;
|
|
view->y = box.y;
|
|
view->w = view->xdg_surface->current.geometry.width;
|
|
view->h = view->xdg_surface->current.geometry.height;
|
|
if (view->w && view->h) {
|
|
view_center(view);
|
|
}
|
|
} else {
|
|
/*
|
|
* If child-toplevel-views, we center-align relative to their
|
|
* parents
|
|
*/
|
|
struct view *parent = parent_of(view);
|
|
assert(parent);
|
|
int center_x = parent->x + parent->w / 2;
|
|
int center_y = parent->y + parent->h / 2;
|
|
view->x = center_x - view->xdg_surface->current.geometry.width / 2;
|
|
view->y = center_y - view->xdg_surface->current.geometry.height / 2;
|
|
}
|
|
view->x += view->margin.left - view->padding.left;
|
|
view->y += view->margin.top - view->padding.top;
|
|
}
|
|
|
|
static const char *
|
|
xdg_toplevel_view_get_string_prop(struct view *view, const char *prop)
|
|
{
|
|
if (!strcmp(prop, "title")) {
|
|
return view->xdg_surface->toplevel->title;
|
|
}
|
|
if (!strcmp(prop, "app_id")) {
|
|
return view->xdg_surface->toplevel->app_id;
|
|
}
|
|
return "";
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_map(struct view *view)
|
|
{
|
|
view->mapped = true;
|
|
view->surface = view->xdg_surface->surface;
|
|
if (!view->been_mapped) {
|
|
/*
|
|
* Start unmaximized to avoid padding/position complications
|
|
* and keep code simple
|
|
*/
|
|
view_maximize(view, false);
|
|
|
|
foreign_toplevel_handle_create(view);
|
|
|
|
view->ssd.enabled = has_ssd(view);
|
|
if (view->ssd.enabled) {
|
|
view->margin = ssd_thickness(view);
|
|
ssd_create(view);
|
|
}
|
|
|
|
update_padding(view);
|
|
position_xdg_toplevel_view(view);
|
|
|
|
struct wlr_subsurface *subsurface;
|
|
wl_list_for_each(subsurface, &view->surface->current.subsurfaces_below,
|
|
current.link) {
|
|
view_subsurface_create(view, subsurface);
|
|
}
|
|
wl_list_for_each(subsurface, &view->surface->current.subsurfaces_above,
|
|
current.link) {
|
|
view_subsurface_create(view, subsurface);
|
|
}
|
|
view_discover_output(view);
|
|
|
|
view->been_mapped = true;
|
|
}
|
|
|
|
view->commit.notify = handle_commit;
|
|
wl_signal_add(&view->xdg_surface->surface->events.commit,
|
|
&view->commit);
|
|
view->new_subsurface.notify = new_subsurface_notify;
|
|
wl_signal_add(&view->surface->events.new_subsurface,
|
|
&view->new_subsurface);
|
|
|
|
view_impl_map(view);
|
|
}
|
|
|
|
static void
|
|
xdg_toplevel_view_unmap(struct view *view)
|
|
{
|
|
if (view->mapped) {
|
|
view->mapped = false;
|
|
damage_all_outputs(view->server);
|
|
wl_list_remove(&view->commit.link);
|
|
wl_list_remove(&view->new_subsurface.link);
|
|
desktop_focus_topmost_mapped_view(view->server);
|
|
}
|
|
}
|
|
|
|
static const struct view_impl xdg_toplevel_view_impl = {
|
|
.configure = xdg_toplevel_view_configure,
|
|
.close = xdg_toplevel_view_close,
|
|
.for_each_popup_surface = xdg_toplevel_view_for_each_popup_surface,
|
|
.for_each_surface = xdg_toplevel_view_for_each_surface,
|
|
.get_string_prop = xdg_toplevel_view_get_string_prop,
|
|
.map = xdg_toplevel_view_map,
|
|
.move = xdg_toplevel_view_move,
|
|
.set_activated = xdg_toplevel_view_set_activated,
|
|
.set_fullscreen = xdg_toplevel_view_set_fullscreen,
|
|
.unmap = xdg_toplevel_view_unmap,
|
|
.maximize = xdg_toplevel_view_maximize,
|
|
};
|
|
|
|
void
|
|
xdg_surface_new(struct wl_listener *listener, void *data)
|
|
{
|
|
struct server *server =
|
|
wl_container_of(listener, server, new_xdg_surface);
|
|
struct wlr_xdg_surface *xdg_surface = data;
|
|
if (xdg_surface->role != WLR_XDG_SURFACE_ROLE_TOPLEVEL) {
|
|
return;
|
|
}
|
|
wlr_xdg_surface_ping(xdg_surface);
|
|
|
|
struct view *view = calloc(1, sizeof(struct view));
|
|
view->server = server;
|
|
view->type = LAB_XDG_SHELL_VIEW;
|
|
view->impl = &xdg_toplevel_view_impl;
|
|
view->xdg_surface = xdg_surface;
|
|
wl_list_init(&view->ssd.parts);
|
|
|
|
xdg_surface->data = view;
|
|
|
|
view->map.notify = handle_map;
|
|
wl_signal_add(&xdg_surface->events.map, &view->map);
|
|
view->unmap.notify = handle_unmap;
|
|
wl_signal_add(&xdg_surface->events.unmap, &view->unmap);
|
|
view->destroy.notify = handle_destroy;
|
|
wl_signal_add(&xdg_surface->events.destroy, &view->destroy);
|
|
|
|
view->new_popup.notify = handle_new_xdg_popup;
|
|
wl_signal_add(&xdg_surface->events.new_popup, &view->new_popup);
|
|
|
|
struct wlr_xdg_toplevel *toplevel = xdg_surface->toplevel;
|
|
view->request_move.notify = handle_request_move;
|
|
wl_signal_add(&toplevel->events.request_move, &view->request_move);
|
|
view->request_resize.notify = handle_request_resize;
|
|
wl_signal_add(&toplevel->events.request_resize, &view->request_resize);
|
|
view->request_maximize.notify = handle_request_maximize;
|
|
wl_signal_add(&toplevel->events.request_maximize, &view->request_maximize);
|
|
view->request_fullscreen.notify = handle_request_fullscreen;
|
|
wl_signal_add(&toplevel->events.request_fullscreen,
|
|
&view->request_fullscreen);
|
|
|
|
view->set_title.notify = handle_set_title;
|
|
wl_signal_add(&toplevel->events.set_title, &view->set_title);
|
|
|
|
view->set_app_id.notify = handle_set_app_id;
|
|
wl_signal_add(&toplevel->events.set_app_id, &view->set_app_id);
|
|
|
|
wl_list_insert(&server->views, &view->link);
|
|
}
|