mirror of
https://github.com/labwc/labwc.git
synced 2025-11-02 09:01:47 -05:00
f56d07aa47
This PR allows applications to activate themselves *if they provide
a valid xdg_activation token* (e.g. raise to the top and get keyboard
focus).
These tokens are given out by the xdg_activation protocol implemented
by wlroots and can be configured by the client requesting the token
in three ways:
- an "empty" token
(apparently used to tell the compositor about "urgency")
- seat / input serial attached
- surface attached
Wlroots makes sure that
- If the client attached the seat / input serial: those two are valid.
- If the client attached a surface: that it has keyboard focus at the
point where the request is finalized. There is a patch [1] pending
for backport to wlroots 0.16 that also allows valid tokens when the
supplied surface had cursor focus.
- a token is only valid for 30 seconds after being given out
The token can then be used by the client or given to other clients by
unspecified means (e.g. via environment variable or dbus) which then
may use the token on their own surface and request activation.
We only handle the actual request activation part:
- If the seat is set on the token we know wlroots validated seat and
input serial
- Thus, if no seat is set we deny the activation request so we don't
have windows suddenly popping up and taking over the keyboard focus
(focus stealing prevention)
- We should also check for the surface being set but we can't do that
with wlroots 0.16 as it will reset the surface to `NULL` when it is
destroyed (which is something that usually happens for
notifications). Once we move to wlroots 0.17.x we can add the
missing surface check because it provides a `new_token` signal.
We can use it to attach further details to the token which are then
verified later when we decide if we allow the activate request or
not.
With this PR in place the following setup should activate windows:
- launching an URL in foot should activate the target application if
it is already running, foot requests a proper token and then sets it
as `XDG_ACTIVATION_TOKEN` environment var before spawning `xdg-open`
- clicking on a `mako` notification with a `default` action defined
should request a proper token which is then given to the application
starting the notification and can thus be used to activate itself
This protocol is still very much in the process of being
implemented / finalized all over the place (e.g. GTK / QT / Firefox /
notification daemons, ..) but we should do our part and remove labwc
from the puzzle of potential issues causing this not to work.
[1]
|
||
|---|---|---|
| .. | ||
| common | ||
| config | ||
| menu | ||
| ssd | ||
| xbm | ||
| action.c | ||
| buffer.c | ||
| cursor.c | ||
| debug.c | ||
| desktop.c | ||
| dnd.c | ||
| foreign.c | ||
| interactive.c | ||
| key-state.c | ||
| keyboard.c | ||
| layers.c | ||
| main.c | ||
| meson.build | ||
| node.c | ||
| osd.c | ||
| output.c | ||
| regions.c | ||
| resistance.c | ||
| seat.c | ||
| server.c | ||
| theme.c | ||
| touch.c | ||
| view-impl.c | ||
| view.c | ||
| workspaces.c | ||
| xdg-deco.c | ||
| xdg-popup.c | ||
| xdg.c | ||
| xwayland-unmanaged.c | ||
| xwayland.c | ||