mirror of
https://github.com/labwc/labwc.git
synced 2025-11-01 22:58:47 -04:00
ef766d16f0
I like the new common/edge.h. I don't like how inconsistently we use it. Current situation: - enum wlr_edges and wlr_direction are designed to be used as bitset, and are defined compatibly - enum lab_edge is *also* designed to be used as bitset, but incompatible with the others (LEFT/RIGHT come before UP/DOWN) - we use an inconsistent mix of all three *AND* uint32_t (usually with the WLR_EDGE constants rather than the LAB_EDGE constants), and convert between them on an ad-hoc basis, sometimes implicitly Let's clean this up: - reorder enum lab_edge to be compatible with the two wlr enums (check this by static_assert) - use TOP/BOTTOM naming rather than UP/DOWN (matches wlr_edges) - add constants for the remaining possible combinations of the 4 edges - use lab_edge for all internal edge/direction fields, consistently - add lab_edge_is_cardinal() as a sanity check before casting to enum wlr_direction, and then eliminate all of direction.c/h Instead of "enum wlr_edges direction", we now have "enum lab_edge direction" which is not that much better. At least we are now clear that we're overloading one enum with two meanings. |
||
|---|---|---|
| .. | ||
| array.h | ||
| border.h | ||
| box.h | ||
| buf.h | ||
| dir.h | ||
| edge.h | ||
| fd-util.h | ||
| file-helpers.h | ||
| font.h | ||
| grab-file.h | ||
| graphic-helpers.h | ||
| lab-scene-rect.h | ||
| list.h | ||
| macros.h | ||
| match.h | ||
| mem.h | ||
| nodename.h | ||
| parse-bool.h | ||
| parse-double.h | ||
| scaled-font-buffer.h | ||
| scaled-icon-buffer.h | ||
| scaled-img-buffer.h | ||
| scaled-scene-buffer.h | ||
| scene-helpers.h | ||
| set.h | ||
| spawn.h | ||
| string-helpers.h | ||
| surface-helpers.h | ||
| xml.h | ||