labwc/src/resistance.c
Andrew J. Hesford 2bf285a2c6 snap: cache and ignore last-snapped edge when growing or shrinking
When growing or shrinking a view by snapping to an edge, a client may
ignore the requested size and instead keep its original size or
substitute a different (possibly constrained) size. In this case, the
view may not actually contact the snapped edge, and a subsequent snap
attempt will just keep re-trying (and failing) to contact the same ege.

To mitigate this, remember the last-snapped view, snapping direction and
offset of the snapping edge in snap.c; when re-attempting a snap for the
same view in the same direction, ignore the edge that was last "hit", to
allow snapping to progress beyond the problematic edge.
2024-04-10 23:30:28 +01:00

153 lines
4.6 KiB
C

// SPDX-License-Identifier: GPL-2.0-only
#include <assert.h>
#include <limits.h>
#include "common/border.h"
#include "common/macros.h"
#include "config/rcxml.h"
#include "edges.h"
#include "labwc.h"
#include "resistance.h"
#include "view.h"
static void
check_edge(int *next, struct edge current, struct edge target,
struct edge oppose, struct edge align, int tolerance, bool lesser)
{
int cur = current.offset;
int tgt = target.offset;
int opp = oppose.offset;
/* Ignore non-moving edges */
if (cur == tgt) {
return;
}
/*
* The edge defined by current and moving to target may encounter two
* edges of another region: the opposing edge of the region is that in
* the opposite orientation of the moving edge (i.e., left <-> right or
* top <-> bottom); the aligned edge of the region is that in the same
* orientation as the moving edge (i.e., left <->left, top <-> top,
* right <-> right, bottom <-> bottom).
*
* Any opposing or aligned edge of a region is considered "valid" in
* this search if the resist/attract zone (defined by tolerance) of
* that edge contains the target position of the moving edge.
*/
/* Direction of motion for the edge */
const bool decreasing = tgt < cur;
/*
* Motion resists "entry" into the space of another window, but never
* resist leaving it. Without edge attraction, this only happens when
* the "leading" edge of a motion (top edge upward, bottom edge
* downward, left edge leftward, right edge rightward) encounters an
* opposing edge. If the motion is not of a leading edge, there is no
* need to check for any resistance.
*
* However, if there is attraction, a "trailing" edge of a motion (top
* edge downward, bottom edge upward, left edge rightward, right edge
* leftward) may be grabbed by the opposing edge of another window as
* it passes. Hence, trailing edges still need to be tested in
* attractive cases.
*/
if (tolerance >= 0 && lesser != decreasing) {
return;
}
/* Check the opposing edge */
bool valid = false;
if (decreasing) {
/* Check for decreasing movement across opposing edge */
const int lo = clipped_sub(opp, abs(tolerance));
const int hi = clipped_sub(opp, MIN(tolerance, 0));
valid = tgt >= lo && tgt < hi && cur >= opp;
} else {
/* Check for increasing movement across opposing edge */
const int lo = clipped_add(opp, MIN(tolerance, 0));
const int hi = clipped_add(opp, abs(tolerance));
valid = tgt > lo && tgt <= hi && cur <= opp;
}
if (valid && edges_traverse_edge(current, target, oppose)) {
*next = edge_get_best(*next, opp, decreasing);
}
}
static void
check_edge_output(int *next, struct edge current, struct edge target,
struct edge oppose, struct edge align, bool lesser)
{
check_edge(next, current, target,
oppose, align, rc.screen_edge_strength, lesser);
}
static void
check_edge_window(int *next, struct edge current, struct edge target,
struct edge oppose, struct edge align, bool lesser)
{
check_edge(next, current, target,
oppose, align, rc.window_edge_strength, lesser);
}
void
resistance_move_apply(struct view *view, double *x, double *y)
{
assert(view);
struct border next_edges;
edges_initialize(&next_edges);
struct wlr_box target = {
.x = *x,
.y = *y,
.width = view->current.width,
.height = view->current.height,
};
if (rc.screen_edge_strength != 0) {
/* Find any relevant output edges encountered by this move */
edges_find_outputs(&next_edges, view,
view->current, target, NULL, check_edge_output);
}
if (rc.window_edge_strength != 0) {
/* Find any relevant window edges encountered by this move */
edges_find_neighbors(&next_edges, view, view->current, target,
NULL, check_edge_window, /* ignore_hidden */ true);
}
/* If any "best" edges were encountered during this move, snap motion */
edges_adjust_move_coords(view, next_edges,
&target.x, &target.y, /* use_pending */ false);
*x = target.x;
*y = target.y;
}
void
resistance_resize_apply(struct view *view, struct wlr_box *new_geom)
{
assert(view);
assert(!view->shaded);
struct border next_edges;
edges_initialize(&next_edges);
if (rc.screen_edge_strength != 0) {
/* Find any relevant output edges encountered by this move */
edges_find_outputs(&next_edges, view,
view->current, *new_geom, NULL, check_edge_output);
}
if (rc.window_edge_strength != 0) {
/* Find any relevant window edges encountered by this move */
edges_find_neighbors(&next_edges, view, view->current, *new_geom,
NULL, check_edge_window, /* ignore_hidden */ true);
}
/* If any "best" edges were encountered during this move, snap motion */
edges_adjust_resize_geom(view, next_edges,
view->server->resize_edges, new_geom, /* use_pending */ false);
}