mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-10-29 05:40:24 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
labwc/include/foreign-toplevel
History
Exact
John Lindgren 02df0a15d7 foreign-toplevel: simplify and fully separate ext-foreign/wlr-foreign 
Currently, the dependencies between foreign-toplevel[-internal],
ext-foreign, and wlr-foreign are cyclical and a bit complex.

I suggest we reorganize it into a simpler hierarchy:

  foreign-toplevel/
    -> foreign.c/h
      -> (depends on) ext-foreign.c/h
      -> (depends on) wlr-foreign.c/h

The refactored code is smaller and (IMO) easier to follow.

In detail:

- Add include/foreign-toplevel folder mirroring src/foreign-toplevel
- Split foreign-toplevel-internal.h to ext-foreign.h and wlr-foreign.h
- Eliminate ext-/wlr-foreign.c -> foreign.c reverse dependencies
  (including internal signals and foreign_request* functions)
- Make struct foreign_toplevel private to foreign.c

Lightly tested with qmpanel (which uses wlr-foreign-toplevel).

v2: reorder foreign-toplevel internal API funcs
2025-08-07 23:27:04 -04:00
..
ext-foreign.h foreign-toplevel: simplify and fully separate ext-foreign/wlr-foreign 2025-08-07 23:27:04 -04:00
foreign.h foreign-toplevel: simplify and fully separate ext-foreign/wlr-foreign 2025-08-07 23:27:04 -04:00
wlr-foreign.h foreign-toplevel: simplify and fully separate ext-foreign/wlr-foreign 2025-08-07 23:27:04 -04:00