mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-03 09:01:51 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Set node position in xdg/xwayland commit handlers

Browse source 
...in order to sync resize/move events to avoid left/bottom edge wobbling
when resizing with top/left resize edges
This commit is contained in:
Johan Malm 2022-02-23 22:39:57 +00:00
parent 581a2bb2f1
commit f4c9d1ba9f
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/view.c
View file

@ -48,7 +48,6 @@ view_move_resize(struct view *view, struct wlr_box geo)
} }
ssd_update_title(view); ssd_update_title(view);
view_discover_output(view); view_discover_output(view);
wlr_scene_node_set_position(&view->scene_tree->node, view->x, view->y);
} }
#define MIN_VIEW_WIDTH (100) #define MIN_VIEW_WIDTH (100)
@ -150,7 +149,6 @@ view_center(struct view *view)
if (view_compute_centered_position(view, view->w, view->h, &x, &y)) { if (view_compute_centered_position(view, view->w, view->h, &x, &y)) {
view_move(view, x, y); view_move(view, x, y);
} }
wlr_scene_node_set_position(&view->scene_tree->node, view->x, view->y);
} }
static void static void
@ -226,7 +224,6 @@ view_maximize(struct view *view, bool maximize)
if (view->fullscreen) { if (view->fullscreen) {
return; return;
} }
wlr_scene_node_set_position(&view->scene_tree->node, view->x, view->y);
if (view->impl->maximize) { if (view->impl->maximize) {
view->impl->maximize(view, maximize); view->impl->maximize(view, maximize);
} }

2
src/xdg.c
View file

@ -57,6 +57,8 @@ handle_commit(struct wl_listener *listener, void *data)
if (serial == view->xdg_surface->current.configure_serial) { if (serial == view->xdg_surface->current.configure_serial) {
view->pending_move_resize.configure_serial = 0; view->pending_move_resize.configure_serial = 0;
} }
wlr_scene_node_set_position(&view->scene_tree->node,
view->x, view->y);
} }
ssd_update_geometry(view); ssd_update_geometry(view);
damage_view_part(view); damage_view_part(view);

6
src/xwayland.c
View file

@ -12,6 +12,8 @@ handle_commit(struct wl_listener *listener, void *data)
/* Must receive commit signal before accessing surface->current* */ /* Must receive commit signal before accessing surface->current* */
view->w = view->surface->current.width; view->w = view->surface->current.width;
view->h = view->surface->current.height; view->h = view->surface->current.height;
bool move_pending = view->pending_move_resize.update_x
|| view->pending_move_resize.update_y;
if (view->pending_move_resize.update_x) { if (view->pending_move_resize.update_x) {
view->x = view->pending_move_resize.x + view->x = view->pending_move_resize.x +
@ -23,6 +25,10 @@ handle_commit(struct wl_listener *listener, void *data)
view->pending_move_resize.height - view->h; view->pending_move_resize.height - view->h;
view->pending_move_resize.update_y = false; view->pending_move_resize.update_y = false;
} }
if (move_pending) {
wlr_scene_node_set_position(&view->scene_tree->node,
view->x, view->y);
}
ssd_update_geometry(view); ssd_update_geometry(view);
damage_view_whole(view); damage_view_whole(view);
} }