From f4b6895c52eb3c1f171bb00cb49e5ed029476c88 Mon Sep 17 00:00:00 2001 From: tokyo4j Date: Sun, 8 Dec 2024 16:05:53 +0900 Subject: [PATCH] Revert "menu: slightly slide menus opened from buttons" With 2ade6a1, negative x-values can be passed to menu_configure() when the window menu is opened from top-left button in a maximized window, but wlr_output_layout_output_at() couldn't find the output for the coordinate since it's out of the output layout, thus it just opened the menu without updating its position. As the next release is close and the visual improvement by 2ade6a1 is not very impactful for UX, let's revert it for now. --- src/action.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/action.c b/src/action.c index 195a9171..9da1b796 100644 --- a/src/action.c +++ b/src/action.c @@ -678,7 +678,6 @@ show_menu(struct server *server, struct view *view, struct cursor_context *ctx, assert(ctx->node); int ly; wlr_scene_node_coords(ctx->node, &x, &ly); - x -= server->theme->menu_border_width; } }