From eba57831f455923558be96cef876c4b08b0f1d3e Mon Sep 17 00:00:00 2001
From: Alex Chernika <me@chernika.dev>
Date: Sat, 11 Apr 2026 14:02:14 +0200
Subject: [PATCH] menu: fix possible buffer over-read in item_create()

---
 src/menu/menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/menu/menu.c b/src/menu/menu.c
index 8df2127c..deec5123 100644
--- a/src/menu/menu.c
+++ b/src/menu/menu.c
@@ -147,8 +147,8 @@ item_create(struct menu *menu, const char *text, const char *icon_name, bool sho
 	const char *it = text;
 	menuitem->accelerator = tolower(*it);
 	while (*it != '\0') {
-		if (*it == '_' && *it != '\0') {
-			menuitem->accelerator = tolower(*(++it));
+		if (*it == '_') {
+			menuitem->accelerator = tolower(*(it + 1));
 			break;
 		}
 		it++;