window-rules: support title criteria

Example config:

    <windowRules>
      <windowRule identifier="foot" title="max">
        <action name="Maximize"/>
      </windowRule>
    </windowRules>

Observe that:

- `foot -T foo` starts maximized
- `xterm -T foo` starts normal
This commit is contained in:
Johan Malm 2023-05-09 21:20:05 +01:00 committed by Johan Malm
parent 63db731cf4
commit d37e705548
5 changed files with 90 additions and 30 deletions

View file

@ -2,6 +2,7 @@
#define _POSIX_C_SOURCE 200809L
#include "config.h"
#include <assert.h>
#include <stdbool.h>
#include <cairo.h>
#include <glib.h>
#include <strings.h>
@ -13,20 +14,44 @@
#include "view.h"
#include "window-rules.h"
/* Try to match against identifier AND title (if set) */
static bool
view_matches_criteria(struct window_rule *rule, struct view *view)
{
const char *id = view_get_string_prop(view, "app_id");
const char *title = view_get_string_prop(view, "title");
if (rule->identifier && rule->title) {
if (!id || !title) {
return false;
}
return match_glob(rule->identifier, id)
&& match_glob(rule->title, title);
} else if (rule->identifier) {
if (!id) {
return false;
}
return match_glob(rule->identifier, id);
} else if (rule->title) {
if (!title) {
return false;
}
return match_glob(rule->title, title);
} else {
wlr_log(WLR_ERROR, "rule has no identifier or title\n");
return false;
}
}
void
window_rules_apply(struct view *view, enum window_rule_event event)
{
const char *identifier = view_get_string_prop(view, "app_id");
if (!identifier) {
return;
}
struct window_rule *rule;
wl_list_for_each(rule, &rc.window_rules, link) {
if (!rule->identifier || rule->event != event) {
if (rule->event != event) {
continue;
}
if (match_glob(rule->identifier, identifier)) {
if (view_matches_criteria(rule, view)) {
actions_run(view, view->server, &rule->actions, 0);
}
}
@ -37,11 +62,6 @@ window_rules_get_property(struct view *view, const char *property)
{
assert(property);
const char *identifier = view_get_string_prop(view, "app_id");
if (!identifier) {
goto out;
}
/*
* We iterate in reverse here because later items in list have higher
* priority. For example, in the config below we want the return value
@ -54,16 +74,13 @@ window_rules_get_property(struct view *view, const char *property)
*/
struct window_rule *rule;
wl_list_for_each_reverse(rule, &rc.window_rules, link) {
if (!rule->identifier) {
continue;
}
/*
* Only return if property != LAB_PROP_UNSPECIFIED otherwise a
* <windowRule> which does not set a particular property
* attribute would still return here if that property was asked
* for.
*/
if (match_glob(rule->identifier, identifier)) {
if (view_matches_criteria(rule, view)) {
if (!strcasecmp(property, "serverDecoration")) {
if (rule->server_decoration) {
return rule->server_decoration;
@ -71,6 +88,5 @@ window_rules_get_property(struct view *view, const char *property)
}
}
}
out:
return LAB_PROP_UNSPECIFIED;
}