mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-04 13:30:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

xdg: try to handle missing set_window_geometry with Qt apps

Browse source 
Qt applications occasionally fail to call set_window_geometry after a
configure request, but do correctly update the actual surface extent.
This results in a mismatch between the window decorations (which follow
the logical geometry) and the visual size of the client area. As a
workaround, try to detect this case and ignore the out-of-date window
geometry.

Fixes: #1194
This commit is contained in:
John Lindgren 2023-10-21 19:49:38 -04:00 • committed by Consolatis
parent 57075ce864
commit d2bcb94bae
1 changed files with 21 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/xdg.c
View file

@ -90,6 +90,27 @@ handle_commit(struct wl_listener *listener, void *data)
struct wlr_box size; struct wlr_box size;
wlr_xdg_surface_get_geometry(xdg_surface, &size); wlr_xdg_surface_get_geometry(xdg_surface, &size);
/*
* Qt applications occasionally fail to call set_window_geometry
* after a configure request, but do correctly update the actual
* surface extent. This results in a mismatch between the window
* decorations (which follow the logical geometry) and the visual
* size of the client area. As a workaround, we try to detect
* this case and ignore the out-of-date window geometry.
*/
if (size.width != view->pending.width
|| size.height != view->pending.height) {
struct wlr_box extent;
wlr_surface_get_extends(xdg_surface->surface, &extent);
if (extent.width == view->pending.width
&& extent.height == view->pending.height) {
wlr_log(WLR_DEBUG, "window geometry for client (%s) "
"appears to be incorrect - ignoring",
view_get_string_prop(view, "app_id"));
size = extent; /* Use surface extent instead */
}
}
struct wlr_box *current = &view->current; struct wlr_box *current = &view->current;
bool update_required = current->width != size.width bool update_required = current->width != size.width
|| current->height != size.height; || current->height != size.height;