mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-02 09:01:47 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

scaled-scene-buffer: implement buffer sharing mechanism

Browse source 
Implementers can define impl->equal() which compares two
scaled-scene-buffers so that buffers are not allocated for visually
duplicated scaled-scene-buffers.

Currently this mechanism isn't applied for scaled-font-buffers since we
haven't defined impl->equal() for it.
This commit is contained in:
tokyo4j 2024-11-19 05:03:26 +09:00 • committed by Johan Malm
parent f071431266
commit c893878aca
3 changed files with 97 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

17
include/common/scaled-scene-buffer.h
View file

@ -17,6 +17,9 @@ struct scaled_scene_buffer_impl {
(struct scaled_scene_buffer *scaled_buffer, double scale);
/* Might be NULL or used for cleaning up */
void (*destroy)(struct scaled_scene_buffer *scaled_buffer);
/* Returns true if the two buffers are visually the same */
bool (*equal)(struct scaled_scene_buffer *scaled_buffer_a,
struct scaled_scene_buffer *scaled_buffer_b);
};
struct scaled_scene_buffer {
@ -28,11 +31,18 @@ struct scaled_scene_buffer {
/* Private */
bool drop_buffer;
double active_scale;
/* cached wlr_buffers for each scale */
struct wl_list cache; /* struct scaled_buffer_cache_entry.link */
struct wl_listener destroy;
struct wl_listener output_enter;
struct wl_listener output_leave;
const struct scaled_scene_buffer_impl *impl;
/*
* Pointer to the per-implementation list of scaled-scene-buffers.
* This is used to share the backing wlr_buffers.
*/
struct wl_list *cached_buffers;
struct wl_list link; /* struct scaled_scene_buffer.cached_buffers */
};
/**
@ -53,6 +63,11 @@ struct scaled_scene_buffer {
* it will also get called so a consumer of this API may clean up its own
* allocations.
*
* Besides caching buffers for each scale per scaled_scene_buffer, we also
* store all the scaled_scene_buffers in a per-implementer list passed as
* @cached_buffers in order to reuse backing buffers for visually duplicated
* scaled_scene_buffers found via impl->equal().
*
* All requested lab_data_buffers via impl->create_buffer() will be locked
* during the lifetime of the buffer in the internal cache and unlocked
* when being evacuated from the cache (due to LAB_SCALED_BUFFER_MAX_CACHE
@ -79,7 +94,7 @@ struct scaled_scene_buffer {
struct scaled_scene_buffer *scaled_scene_buffer_create(
struct wlr_scene_tree *parent,
const struct scaled_scene_buffer_impl *implementation,
bool drop_buffer);
struct wl_list *cached_buffers, bool drop_buffer);
/* Clear the cache of existing buffers, useful in case the content changes */
void scaled_scene_buffer_invalidate_cache(struct scaled_scene_buffer *self);