mirrors/labwc
1
0
Fork 0
mirror of https://github.com/labwc/labwc.git synced 2025-11-04 13:30:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "xwayland: Fix size issue when starting VLC fullscreen"

Browse source 
The fix caused a couple of issues:

1. Ignoring client configure requests caused some clients to hang
   and not repaint correctly. We are supposed to synthesize a
   ConfigureNotify event when ignore/override a client configure
   request, but this isn't possible with current wlroots.

2. Setting view->natural_geometry from client configure requests
   resulted in overwriting good values with bad in some cases (e.g.
   with tiled xfce4-terminal in xwayland mode).

For now, revert the fix. This does allow clients to mess with view
positioning for maximized/fullscreen/tiled views, but right now the
alternatives seem worse.

The original specific issue (VLC undoing its fullscreen geometry)
is arguably a bug in VLC anyway.

This reverts commit 09599861ac.
This commit is contained in:
John Lindgren 2023-02-17 13:50:44 -05:00 • committed by Consolatis
parent 49c9466039
commit 913f89b6c4
1 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/xwayland.c
View file

@ -305,20 +305,6 @@ handle_request_configure(struct wl_listener *listener, void *data)
int height = event->height; int height = event->height;
view_adjust_size(view, &width, &height); view_adjust_size(view, &width, &height);
/*
* If a configure request is received while maximized/
* fullscreen/tiled, update the natural geometry only. This
* appears to be the desired behavior e.g. when starting VLC in
* fullscreen mode.
*/
if (!view_is_floating(view)) {
view->natural_geometry.x = event->x;
view->natural_geometry.y = event->y;
view->natural_geometry.width = width;
view->natural_geometry.height = height;
return;
}
configure(view, (struct wlr_box){event->x, event->y, width, height}); configure(view, (struct wlr_box){event->x, event->y, width, height});
} }